Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lift state for error to Comments #10341

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Lift state for error to Comments #10341

merged 5 commits into from
Jan 29, 2024

Conversation

DanielCliftonGuardian
Copy link
Contributor

@DanielCliftonGuardian DanielCliftonGuardian commented Jan 25, 2024 •
edited
Loading

What does this change?

Lift state for error to Comments

Why?

Part of #10225

Screenshots

Testing on code:

image image

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

Deploy build 46161 of dotcom:rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

Deploy build 7301 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

Size Change: +50 B (0%)

Total Size: 750 kB

ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/11.client.web.********************.js 5.78 kB 0 B
dotcom-rendering/dist/112.client.web.********************.js 823 B 0 B
dotcom-rendering/dist/1191.client.web.********************.js 679 B 0 B
dotcom-rendering/dist/1229.client.web.********************.js 8.67 kB 0 B
dotcom-rendering/dist/1407.client.web.********************.js 639 B 0 B
dotcom-rendering/dist/1412.client.web.********************.js 4.31 kB 0 B
dotcom-rendering/dist/1459.client.web.********************.js 877 B 0 B
dotcom-rendering/dist/1749.client.web.********************.js 920 B 0 B
dotcom-rendering/dist/1955.client.web.********************.js 4.71 kB 0 B
dotcom-rendering/dist/2132.client.web.********************.js 5.09 kB 0 B
dotcom-rendering/dist/2276.client.web.********************.js 3.35 kB 0 B
dotcom-rendering/dist/2293.client.web.********************.js 581 B 0 B
dotcom-rendering/dist/307.client.web.********************.js 13.2 kB 0 B
dotcom-rendering/dist/3314.client.web.********************.js 4.76 kB 0 B
dotcom-rendering/dist/3375.client.web.********************.js 2.7 kB 0 B
dotcom-rendering/dist/3410.client.web.********************.js 2.68 kB 0 B
dotcom-rendering/dist/3889.client.web.********************.js 8.24 kB 0 B
dotcom-rendering/dist/393.client.web.********************.js 921 B 0 B
dotcom-rendering/dist/3958.client.web.********************.js 39.9 kB 0 B
dotcom-rendering/dist/3986.client.web.********************.js 496 B 0 B
dotcom-rendering/dist/4002.client.web.********************.js 4.59 kB 0 B
dotcom-rendering/dist/4040.client.web.********************.js 651 B 0 B
dotcom-rendering/dist/4045.client.web.********************.js 642 B 0 B
dotcom-rendering/dist/405.client.web.********************.js 915 B 0 B
dotcom-rendering/dist/4215.client.web.********************.js 409 B 0 B
dotcom-rendering/dist/4219.client.web.********************.js 5.74 kB 0 B
dotcom-rendering/dist/4265.client.web.********************.js 2.38 kB 0 B
dotcom-rendering/dist/4269.client.web.********************.js 667 B 0 B
dotcom-rendering/dist/4298.client.web.********************.js 8.41 kB 0 B
dotcom-rendering/dist/4390.client.web.********************.js 507 B 0 B
dotcom-rendering/dist/4438.client.web.********************.js 802 B 0 B
dotcom-rendering/dist/4442.client.web.********************.js 712 B 0 B
dotcom-rendering/dist/478.client.web.********************.js 594 B 0 B
dotcom-rendering/dist/4870.client.web.********************.js 747 B 0 B
dotcom-rendering/dist/4911.client.web.********************.js 780 B 0 B
dotcom-rendering/dist/4982.client.web.********************.js 3.82 kB 0 B
dotcom-rendering/dist/5020.client.web.********************.js 994 B 0 B
dotcom-rendering/dist/5041.client.web.********************.js 3.76 kB 0 B
dotcom-rendering/dist/5047.client.web.********************.js 779 B 0 B
dotcom-rendering/dist/5144.client.web.********************.js 5.08 kB 0 B
dotcom-rendering/dist/5242.client.web.********************.js 529 B 0 B
dotcom-rendering/dist/5290.client.web.********************.js 3.24 kB 0 B
dotcom-rendering/dist/5499.client.web.********************.js 2.47 kB 0 B
dotcom-rendering/dist/5619.client.web.********************.js 926 B 0 B
dotcom-rendering/dist/5730.client.web.********************.js 954 B 0 B
dotcom-rendering/dist/5772.client.web.********************.js 9.97 kB 0 B
dotcom-rendering/dist/5957.client.web.********************.js 5.93 kB 0 B
dotcom-rendering/dist/5985.client.web.********************.js 748 B 0 B
dotcom-rendering/dist/6043.client.web.********************.js 852 B 0 B
dotcom-rendering/dist/6140.client.web.********************.js 852 B 0 B
dotcom-rendering/dist/6651.client.web.********************.js 905 B 0 B
dotcom-rendering/dist/6693.client.web.********************.js 823 B 0 B
dotcom-rendering/dist/6756.client.web.********************.js 525 B 0 B
dotcom-rendering/dist/6853.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/7018.client.web.********************.js 787 B 0 B
dotcom-rendering/dist/7167.client.web.********************.js 16.5 kB 0 B
dotcom-rendering/dist/7329.client.web.********************.js 2.77 kB 0 B
dotcom-rendering/dist/7356.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/7554.client.web.********************.js 3.27 kB 0 B
dotcom-rendering/dist/7629.client.web.********************.js 2.87 kB 0 B
dotcom-rendering/dist/7855.client.web.********************.js 787 B 0 B
dotcom-rendering/dist/7983.client.web.********************.js 3.1 kB 0 B
dotcom-rendering/dist/8002.client.web.********************.js 801 B 0 B
dotcom-rendering/dist/8113.client.web.********************.js 3.48 kB 0 B
dotcom-rendering/dist/8288.client.web.********************.js 23 kB 0 B
dotcom-rendering/dist/8310.client.web.********************.js 3.74 kB 0 B
dotcom-rendering/dist/8344.client.web.********************.js 1.56 kB 0 B
dotcom-rendering/dist/8388.client.web.********************.js 618 B 0 B
dotcom-rendering/dist/841.client.web.********************.js 788 B 0 B
dotcom-rendering/dist/8784.client.web.********************.js 5.09 kB 0 B
dotcom-rendering/dist/8818.client.web.********************.js 746 B 0 B
dotcom-rendering/dist/8937.client.web.********************.js 888 B 0 B
dotcom-rendering/dist/9004.client.web.********************.js 5.85 kB 0 B
dotcom-rendering/dist/9106.client.web.********************.js 2.93 kB 0 B
dotcom-rendering/dist/9173.client.web.********************.js 724 B 0 B
dotcom-rendering/dist/9314.client.web.********************.js 823 B 0 B
dotcom-rendering/dist/9343.client.web.********************.js 2.98 kB 0 B
dotcom-rendering/dist/9458.client.web.********************.js 4.82 kB 0 B
dotcom-rendering/dist/9529.client.web.********************.js 3.24 kB 0 B
dotcom-rendering/dist/958.client.web.********************.js 3.17 kB 0 B
dotcom-rendering/dist/9591.client.web.********************.js 1.85 kB 0 B
dotcom-rendering/dist/9621.client.web.********************.js 719 B 0 B
dotcom-rendering/dist/9676.client.web.********************.js 888 B 0 B
dotcom-rendering/dist/9856.client.web.********************.js 5.75 kB 0 B
dotcom-rendering/dist/9879.client.web.********************.js 3.38 kB 0 B
dotcom-rendering/dist/9978.client.web.********************.js 960 B 0 B
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js 3.72 kB 0 B
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js 425 B 0 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js 4.09 kB 0 B
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js 3.57 kB 0 B
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js 3 kB 0 B
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js 2.42 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js 3.58 kB 0 B
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/Branding-importable.client.web.********************.js 2.54 kB 0 B
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js 5.26 kB 0 B
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js 6.75 kB 0 B
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js 5.76 kB 0 B
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js 4.43 kB 0 B
dotcom-rendering/dist/Carousel-importable.client.web.********************.js 5.52 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js 5.65 kB 0 B
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js 541 B 0 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js 3.24 kB 0 B
dotcom-rendering/dist/DiscussionContainer-importable.client.web.********************.js 23.5 kB +53 B (0%)
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js 4.01 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js 3.57 kB 0 B
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js 4.13 kB 0 B
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js 2.55 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js 3.35 kB 0 B
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js 609 B 0 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js 789 B 0 B
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js 341 B 0 B
dotcom-rendering/dist/frameworks.client.web.********************.js 20.7 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js 3.76 kB 0 B
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js 10.7 kB 0 B
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js 1.63 kB 0 B
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js 2.62 kB 0 B
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js 14.7 kB 0 B
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js 9.29 kB 0 B
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js 781 B 0 B
dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js 10.9 kB 0 B
dotcom-rendering/dist/index.client.web.********************.js 47.2 kB -3 B (0%)
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js 3.67 kB 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js 6.09 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js 4.66 kB 0 B
dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js 3.45 kB 0 B
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js 4.55 kB 0 B
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js 3.54 kB 0 B
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js 2.13 kB 0 B
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js 433 B 0 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js 6.46 kB 0 B
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js 3.59 kB 0 B
dotcom-rendering/dist/Liveness-importable.client.web.********************.js 4.93 kB 0 B
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js 6.61 kB 0 B
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js 5.66 kB 0 B
dotcom-rendering/dist/Metrics-importable.client.web.********************.js 2.29 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js 4.04 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js 6.74 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.client.web.********************.js 4.45 kB 0 B
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js 4.26 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js 3.65 kB 0 B
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js 543 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js 802 B 0 B
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js 749 B 0 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js 539 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js 470 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js 1.89 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.client.web.********************.js 5.77 kB 0 B
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js 1.99 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js 6.21 kB 0 B
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js 3.5 kB 0 B
dotcom-rendering/dist/SendAMessage-importable.client.web.********************.js 4.39 kB 0 B
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js 2.11 kB 0 B
dotcom-rendering/dist/sentry.client.web.********************.js 771 B 0 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js 3.37 kB 0 B
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js 481 B 0 B
dotcom-rendering/dist/shimport.client.web.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js 646 B 0 B
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js 5.71 kB 0 B
dotcom-rendering/dist/SignInGateMain.client.web.********************.js 3.9 kB 0 B
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js 5 kB 0 B
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js 5.63 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js 6.83 kB 0 B
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js 5.49 kB 0 B
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js 5.37 kB 0 B
dotcom-rendering/dist/SubNav-importable.client.web.********************.js 2.24 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js 5.89 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js 3.1 kB 0 B
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js 1.24 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js 1.02 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js 3.68 kB 0 B
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js 5.66 kB 0 B
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js 3.51 kB 0 B
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js 5.45 kB 0 B
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js 3.9 kB 0 B

compressed-size-action

@DanielCliftonGuardian DanielCliftonGuardian marked this pull request as ready for review January 26, 2024 09:33
@DanielCliftonGuardian DanielCliftonGuardian requested a review from a team as a code owner January 26, 2024 09:33
@github-actions GitHub Actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

Click here to see the Chromatic project.

mxdvl
mxdvl approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for testing on CODE

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

Deploy build 31342 of Mobile::mobile-apps-rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Jan 29, 2024
@DanielCliftonGuardian DanielCliftonGuardian merged commit 3ab6dd5 into main Jan 29, 2024
28 checks passed
@DanielCliftonGuardian DanielCliftonGuardian deleted the comment-form-lift-state-error branch January 29, 2024 10:15
@prout-bot
Copy link

Seen on PROD (merged by @DanielCliftonGuardian 7 minutes and 48 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxdvl mxdvl mxdvl approved these changes

Assignees
No one assigned
Labels
dotcom-rendering run_chromatic Runs chromatic when label is applied Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielCliftonGuardian @prout-bot @mxdvl