-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share button #10422
Share button #10422
Conversation
Size Change: +5.62 kB (+1%) Total Size: 767 kB
ℹ️ View Unchanged
|
Hello 👋! When you're ready to run Chromatic, please apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've got some things left to do here - It might be worth implementing the ShareButton
in Storybook first and then replacing the ShareIcons
in a second PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
A few comments/suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small thoughts, but no blocker!
Well done on seeing this through.
I think it’s a little unfortunate we jump through so many hoops to change the width of the button, but as you’ve explained it is necessary to prevent the button changing sizes when its label changes.
Co-Authored-By: Max Duval <hi@mxdvl.com> Co-Authored-By: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
…dering into share-button
Seen on PROD (merged by @DanielCliftonGuardian 12 minutes and 23 seconds ago) Please check your changes! |
What does this change?
Replaces share icons with a share button
Figma: https://www.figma.com/file/RiZvH3U3juhBxYTvcqFJe0/Share-button?type=design&node-id=175-1452&mode=design&t=U3CABoKy2bHNmAUX-0
Why?
Editorial would like to to simplify the share buttons.
Resolves #9832
Screenshots
Screen.Recording.2024-02-13.at.12.39.12.mov