-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display max file size warning for callout file inputs #10623
Conversation
Size Change: +3.79 kB (+1%) Total Size: 760 kB
ℹ️ View Unchanged
|
916ce8e
to
037ed45
Compare
Hello 👋! When you're ready to run Chromatic, please apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but there are some failing actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Chromatic might be failing due to this? https://status.chromatic.com/incident/329017
c5896d6
to
da3a439
Compare
Seen on PROD (merged by @abeddow91 9 minutes and 57 seconds ago) Please check your changes! |
What does this change?
Bumps several source packages and makes use of the new max file size input warning by adding a 6mb max file warning on callout file inputs.
Version bumps are
Why?
We have a max file size of 6mb due to lambda restrictions. We want to communicate this to readers before they try and upload files. This warning is available in
@guardian/source-react-components-development-kitchen
v18. This package is dependent on@guardian/eslint-plugin-source-react-components
and@guardian/source-react-components
so these are also being bumped to their latest version.Screenshots