Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display max file size warning for callout file inputs #10623

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

abeddow91
Copy link
Contributor

@abeddow91 abeddow91 commented Feb 19, 2024

What does this change?

Bumps several source packages and makes use of the new max file size input warning by adding a 6mb max file warning on callout file inputs.

Version bumps are

  • "@guardian/eslint-plugin-source-react-components": "24.0.0"
  • "@guardian/source-react-components": "22.0.1"
  • "@guardian/source-react-components-development-kitchen": "19.0.0"

Why?

We have a max file size of 6mb due to lambda restrictions. We want to communicate this to readers before they try and upload files. This warning is available in @guardian/source-react-components-development-kitchen v18. This package is dependent on @guardian/eslint-plugin-source-react-components and @guardian/source-react-components so these are also being bumped to their latest version.

Screenshots

Before After
before after

@abeddow91 abeddow91 added run_chromatic Runs chromatic when label is applied and removed dotcom-rendering labels Feb 19, 2024
Copy link

github-actions bot commented Feb 19, 2024

Size Change: +3.79 kB (+1%)

Total Size: 760 kB

Filename Size Change
dotcom-rendering/dist/1138.client.web.********************.js 0 B -3.4 kB (removed) 🏆
dotcom-rendering/dist/1567.client.web.********************.js 0 B -3.74 kB (removed) 🏆
dotcom-rendering/dist/1617.client.web.********************.js 0 B -2.88 kB (removed) 🏆
dotcom-rendering/dist/176.client.web.********************.js 0 B -3.35 kB (removed) 🏆
dotcom-rendering/dist/1960.client.web.********************.js 0 B -5.94 kB (removed) 🏆
dotcom-rendering/dist/2054.client.web.********************.js 0 B -5.74 kB (removed) 🏆
dotcom-rendering/dist/286.client.web.********************.js 0 B -8.24 kB (removed) 🏆
dotcom-rendering/dist/3178.client.web.********************.js 0 B -5.85 kB (removed) 🏆
dotcom-rendering/dist/4097.client.web.********************.js 0 B -3.38 kB (removed) 🏆
dotcom-rendering/dist/4669.client.web.********************.js 0 B -4.33 kB (removed) 🏆
dotcom-rendering/dist/4759.client.web.********************.js 0 B -2.78 kB (removed) 🏆
dotcom-rendering/dist/4771.client.web.********************.js 0 B -2.98 kB (removed) 🏆
dotcom-rendering/dist/5387.client.web.********************.js 0 B -2.46 kB (removed) 🏆
dotcom-rendering/dist/5969.client.web.********************.js 0 B -3.48 kB (removed) 🏆
dotcom-rendering/dist/6184.client.web.********************.js 0 B -3.23 kB (removed) 🏆
dotcom-rendering/dist/7245.client.web.********************.js 0 B -2.39 kB (removed) 🏆
dotcom-rendering/dist/7326.client.web.********************.js 0 B -4.71 kB (removed) 🏆
dotcom-rendering/dist/7837.client.web.********************.js 0 B -3.83 kB (removed) 🏆
dotcom-rendering/dist/8079.client.web.********************.js 0 B -5.1 kB (removed) 🏆
dotcom-rendering/dist/8573.client.web.********************.js 0 B -3.11 kB (removed) 🏆
dotcom-rendering/dist/8608.client.web.********************.js 0 B -4.59 kB (removed) 🏆
dotcom-rendering/dist/8821.client.web.********************.js 0 B -3.26 kB (removed) 🏆
dotcom-rendering/dist/9335.client.web.********************.js 0 B -4.77 kB (removed) 🏆
dotcom-rendering/dist/9472.client.web.********************.js 0 B -3.17 kB (removed) 🏆
dotcom-rendering/dist/961.client.web.********************.js 0 B -2.68 kB (removed) 🏆
dotcom-rendering/dist/index.client.web.********************.js 47.4 kB +106 B (0%)
dotcom-rendering/dist/1011.client.web.********************.js 3.14 kB +3.14 kB (new file) 🆕
dotcom-rendering/dist/102.client.web.********************.js 5.09 kB +5.09 kB (new file) 🆕
dotcom-rendering/dist/1519.client.web.********************.js 6.12 kB +6.12 kB (new file) 🆕
dotcom-rendering/dist/1541.client.web.********************.js 2.89 kB +2.89 kB (new file) 🆕
dotcom-rendering/dist/1549.client.web.********************.js 4.81 kB +4.81 kB (new file) 🆕
dotcom-rendering/dist/1827.client.web.********************.js 2.65 kB +2.65 kB (new file) 🆕
dotcom-rendering/dist/1937.client.web.********************.js 2.43 kB +2.43 kB (new file) 🆕
dotcom-rendering/dist/2364.client.web.********************.js 3.79 kB +3.79 kB (new file) 🆕
dotcom-rendering/dist/2443.client.web.********************.js 3 kB +3 kB (new file) 🆕
dotcom-rendering/dist/3936.client.web.********************.js 2.81 kB +2.81 kB (new file) 🆕
dotcom-rendering/dist/4055.client.web.********************.js 3.2 kB +3.2 kB (new file) 🆕
dotcom-rendering/dist/4458.client.web.********************.js 3.44 kB +3.44 kB (new file) 🆕
dotcom-rendering/dist/5055.client.web.********************.js 4.6 kB +4.6 kB (new file) 🆕
dotcom-rendering/dist/5569.client.web.********************.js 3.56 kB +3.56 kB (new file) 🆕
dotcom-rendering/dist/5898.client.web.********************.js 4.33 kB +4.33 kB (new file) 🆕
dotcom-rendering/dist/6302.client.web.********************.js 2.68 kB +2.68 kB (new file) 🆕
dotcom-rendering/dist/6351.client.web.********************.js 3.42 kB +3.42 kB (new file) 🆕
dotcom-rendering/dist/6981.client.web.********************.js 3.87 kB +3.87 kB (new file) 🆕
dotcom-rendering/dist/7024.client.web.********************.js 3.6 kB +3.6 kB (new file) 🆕
dotcom-rendering/dist/7324.client.web.********************.js 3.49 kB +3.49 kB (new file) 🆕
dotcom-rendering/dist/764.client.web.********************.js 6.02 kB +6.02 kB (new file) 🆕
dotcom-rendering/dist/898.client.web.********************.js 3.74 kB +3.74 kB (new file) 🆕
dotcom-rendering/dist/9140.client.web.********************.js 8.28 kB +8.28 kB (new file) 🆕
dotcom-rendering/dist/9605.client.web.********************.js 4.79 kB +4.79 kB (new file) 🆕
dotcom-rendering/dist/9727.client.web.********************.js 5.89 kB +5.89 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
dotcom-rendering/dist/112.client.web.********************.js 822 B 0 B
dotcom-rendering/dist/1191.client.web.********************.js 680 B 0 B
dotcom-rendering/dist/1407.client.web.********************.js 640 B 0 B
dotcom-rendering/dist/1429.client.web.********************.js 17.9 kB 0 B
dotcom-rendering/dist/1459.client.web.********************.js 876 B 0 B
dotcom-rendering/dist/1530.client.web.********************.js 8.47 kB 0 B
dotcom-rendering/dist/17.client.web.********************.js 1.85 kB 0 B
dotcom-rendering/dist/1749.client.web.********************.js 920 B 0 B
dotcom-rendering/dist/190.client.web.********************.js 2.53 kB 0 B
dotcom-rendering/dist/2293.client.web.********************.js 582 B 0 B
dotcom-rendering/dist/2363.client.web.********************.js 5.75 kB 0 B
dotcom-rendering/dist/3170.client.web.********************.js 527 B 0 B
dotcom-rendering/dist/3235.client.web.********************.js 529 B 0 B
dotcom-rendering/dist/3375.client.web.********************.js 2.7 kB 0 B
dotcom-rendering/dist/351.client.web.********************.js 618 B 0 B
dotcom-rendering/dist/3671.client.web.********************.js 435 B 0 B
dotcom-rendering/dist/3737.client.web.********************.js 2.94 kB 0 B
dotcom-rendering/dist/393.client.web.********************.js 920 B 0 B
dotcom-rendering/dist/397.client.web.********************.js 5.77 kB -1 B (0%)
dotcom-rendering/dist/3986.client.web.********************.js 495 B 0 B
dotcom-rendering/dist/4025.client.web.********************.js 39.9 kB 0 B
dotcom-rendering/dist/4040.client.web.********************.js 650 B 0 B
dotcom-rendering/dist/4045.client.web.********************.js 643 B 0 B
dotcom-rendering/dist/405.client.web.********************.js 914 B 0 B
dotcom-rendering/dist/4269.client.web.********************.js 668 B 0 B
dotcom-rendering/dist/4390.client.web.********************.js 508 B 0 B
dotcom-rendering/dist/4438.client.web.********************.js 801 B 0 B
dotcom-rendering/dist/4442.client.web.********************.js 714 B 0 B
dotcom-rendering/dist/478.client.web.********************.js 595 B 0 B
dotcom-rendering/dist/4870.client.web.********************.js 748 B 0 B
dotcom-rendering/dist/4911.client.web.********************.js 780 B 0 B
dotcom-rendering/dist/5020.client.web.********************.js 994 B 0 B
dotcom-rendering/dist/5047.client.web.********************.js 779 B 0 B
dotcom-rendering/dist/5196.client.web.********************.js 13.2 kB +2 B (0%)
dotcom-rendering/dist/5619.client.web.********************.js 926 B 0 B
dotcom-rendering/dist/5730.client.web.********************.js 954 B 0 B
dotcom-rendering/dist/5865.client.web.********************.js 23 kB -5 B (0%)
dotcom-rendering/dist/5985.client.web.********************.js 750 B 0 B
dotcom-rendering/dist/6043.client.web.********************.js 852 B 0 B
dotcom-rendering/dist/6140.client.web.********************.js 853 B 0 B
dotcom-rendering/dist/6651.client.web.********************.js 904 B 0 B
dotcom-rendering/dist/6693.client.web.********************.js 822 B 0 B
dotcom-rendering/dist/6847.client.web.********************.js 4.82 kB +2 B (0%)
dotcom-rendering/dist/6853.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/7018.client.web.********************.js 787 B 0 B
dotcom-rendering/dist/7356.client.web.********************.js 1 kB 0 B
dotcom-rendering/dist/7855.client.web.********************.js 788 B 0 B
dotcom-rendering/dist/8002.client.web.********************.js 801 B 0 B
dotcom-rendering/dist/8030.client.web.********************.js 3.77 kB -3 B (0%)
dotcom-rendering/dist/8166.client.web.********************.js 1.56 kB 0 B
dotcom-rendering/dist/8288.client.web.********************.js 23 kB 0 B
dotcom-rendering/dist/841.client.web.********************.js 789 B 0 B
dotcom-rendering/dist/8695.client.web.********************.js 8.67 kB +2 B (0%)
dotcom-rendering/dist/8749.client.web.********************.js 3.24 kB +3 B (0%)
dotcom-rendering/dist/8818.client.web.********************.js 748 B 0 B
dotcom-rendering/dist/8937.client.web.********************.js 888 B 0 B
dotcom-rendering/dist/9173.client.web.********************.js 723 B 0 B
dotcom-rendering/dist/9314.client.web.********************.js 822 B 0 B
dotcom-rendering/dist/9621.client.web.********************.js 723 B 0 B
dotcom-rendering/dist/9676.client.web.********************.js 889 B 0 B
dotcom-rendering/dist/9886.client.web.********************.js 9.99 kB -2 B (0%)
dotcom-rendering/dist/9933.client.web.********************.js 5.1 kB -1 B (0%)
dotcom-rendering/dist/9978.client.web.********************.js 960 B 0 B
dotcom-rendering/dist/AdPortals-importable.client.web.********************.js 3.72 kB +1 B (0%)
dotcom-rendering/dist/AlreadyVisited-importable.client.web.********************.js 424 B 0 B
dotcom-rendering/dist/AppsEpic-importable.client.web.********************.js 4.12 kB +23 B (+1%)
dotcom-rendering/dist/AppsFooter-importable.client.web.********************.js 3.62 kB +49 B (+1%)
dotcom-rendering/dist/AppsLightboxImage-importable.client.web.********************.js 3 kB 0 B
dotcom-rendering/dist/AppsLightboxImageStore-importable.client.web.********************.js 2.42 kB 0 B
dotcom-rendering/dist/AudioAtomWrapper-importable.client.web.********************.js 3.63 kB +50 B (+1%)
dotcom-rendering/dist/AustralianTerritorySwitcher-importable.client.web.********************.js 2.03 kB +20 B (+1%)
dotcom-rendering/dist/Branding-importable.client.web.********************.js 2.65 kB +46 B (+2%)
dotcom-rendering/dist/braze-web-sdk-core.client.web.********************.js 36.9 kB 0 B
dotcom-rendering/dist/BrazeMessaging-importable.client.web.********************.js 5.29 kB -1 B (0%)
dotcom-rendering/dist/CalloutBlockComponent-importable.client.web.********************.js 6.78 kB +20 B (0%)
dotcom-rendering/dist/CalloutEmbedBlockComponent-importable.client.web.********************.js 5.78 kB +12 B (0%)
dotcom-rendering/dist/CardCommentCount-importable.client.web.********************.js 4.47 kB +42 B (+1%)
dotcom-rendering/dist/Carousel-importable.client.web.********************.js 5.56 kB 0 B
dotcom-rendering/dist/CarouselForNewsletters-importable.client.web.********************.js 5.66 kB 0 B
dotcom-rendering/dist/ChartAtom-importable.client.web.********************.js 538 B 0 B
dotcom-rendering/dist/CommentCount-importable.client.web.********************.js 3.29 kB +46 B (+1%)
dotcom-rendering/dist/DiscussionApps-importable.client.web.********************.js 859 B 0 B
dotcom-rendering/dist/DiscussionMeta-importable.client.web.********************.js 4.06 kB +45 B (+1%)
dotcom-rendering/dist/DiscussionWeb-importable.client.web.********************.js 1.67 kB 0 B
dotcom-rendering/dist/DocumentBlockComponent-importable.client.web.********************.js 3.61 kB +31 B (+1%)
dotcom-rendering/dist/EmbedBlockComponent-importable.client.web.********************.js 4.16 kB +28 B (+1%)
dotcom-rendering/dist/EnhancePinnedPost-importable.client.web.********************.js 2.01 kB 0 B
dotcom-rendering/dist/FetchOnwardsData-importable.client.web.********************.js 2.55 kB 0 B
dotcom-rendering/dist/FilterKeyEventsToggle-importable.client.web.********************.js 3.35 kB -2 B (0%)
dotcom-rendering/dist/FocusStyles-importable.client.web.********************.js 611 B 0 B
dotcom-rendering/dist/FollowWrapper-importable.client.web.********************.js 841 B +48 B (+6%) 🔍
dotcom-rendering/dist/FooterLabel-importable.client.web.********************.js 342 B 0 B
dotcom-rendering/dist/frameworks.client.web.********************.js 20.7 kB 0 B
dotcom-rendering/dist/GetCricketScoreboard-importable.client.web.********************.js 3.82 kB +53 B (+1%)
dotcom-rendering/dist/GetMatchNav-importable.client.web.********************.js 10.8 kB +14 B (0%)
dotcom-rendering/dist/GetMatchStats-importable.client.web.********************.js 1.68 kB +46 B (+3%)
dotcom-rendering/dist/GetMatchTabs-importable.client.web.********************.js 2.67 kB +50 B (+2%)
dotcom-rendering/dist/guardian-braze-components-banner.client.web.********************.js 14.8 kB +47 B (0%)
dotcom-rendering/dist/guardian-braze-components-end-of-article.client.web.********************.js 9.32 kB +36 B (0%)
dotcom-rendering/dist/GuideAtomWrapper-importable.client.web.********************.js 780 B 0 B
dotcom-rendering/dist/HeaderTopBar-importable.client.web.********************.js 10.9 kB -1 B (0%)
dotcom-rendering/dist/InstagramBlockComponent-importable.client.web.********************.js 3.7 kB +28 B (+1%)
dotcom-rendering/dist/InteractiveAtomMessenger-importable.client.web.********************.js 855 B 0 B
dotcom-rendering/dist/InteractiveBlockComponent-importable.client.web.********************.js 6.09 kB 0 B
dotcom-rendering/dist/InteractiveContentsBlockComponent-importable.client.web.********************.js 4.72 kB +60 B (+1%)
dotcom-rendering/dist/InteractiveSupportButton-importable.client.web.********************.js 3.49 kB +32 B (+1%)
dotcom-rendering/dist/KeyEventsCarousel-importable.client.web.********************.js 4.59 kB +34 B (+1%)
dotcom-rendering/dist/KnowledgeQuizAtom-importable.client.web.********************.js 3.54 kB -2 B (0%)
dotcom-rendering/dist/LatestLinks-importable.client.web.********************.js 2.22 kB +82 B (+4%)
dotcom-rendering/dist/LightboxHash-importable.client.web.********************.js 434 B 0 B
dotcom-rendering/dist/LightboxLayout-importable.client.web.********************.js 6.46 kB -2 B (0%)
dotcom-rendering/dist/LiveBlogEpic-importable.client.web.********************.js 3.6 kB +2 B (0%)
dotcom-rendering/dist/Liveness-importable.client.web.********************.js 4.95 kB +12 B (0%)
dotcom-rendering/dist/ManyNewsletterSignUp-importable.client.web.********************.js 6.63 kB +21 B (0%)
dotcom-rendering/dist/MapEmbedBlockComponent-importable.client.web.********************.js 5.69 kB +26 B (0%)
dotcom-rendering/dist/Metrics-importable.client.web.********************.js 2.29 kB 0 B
dotcom-rendering/dist/MostViewedFooter-importable.client.web.********************.js 4.04 kB 0 B
dotcom-rendering/dist/MostViewedFooterData-importable.client.web.********************.js 6.73 kB 0 B
dotcom-rendering/dist/MostViewedRightWrapper-importable.client.web.********************.js 4.44 kB +4 B (0%)
dotcom-rendering/dist/OnwardsUpper-importable.client.web.********************.js 4.29 kB 0 B
dotcom-rendering/dist/PersonalityQuizAtom-importable.client.web.********************.js 3.66 kB -3 B (0%)
dotcom-rendering/dist/ProfileAtom-importable.client.web.********************.js 542 B 0 B
dotcom-rendering/dist/ProfileAtomWrapper-importable.client.web.********************.js 800 B 0 B
dotcom-rendering/dist/PulsingDot-importable.client.web.********************.js 749 B 0 B
dotcom-rendering/dist/QandaAtom-importable.client.web.********************.js 537 B 0 B
dotcom-rendering/dist/ReaderRevenueDev-importable.client.web.********************.js 469 B 0 B
dotcom-rendering/dist/readerRevenueDevUtils.client.web.********************.js 1.9 kB 0 B
dotcom-rendering/dist/ReaderRevenueLinks-importable.client.web.********************.js 5.78 kB 0 B
dotcom-rendering/dist/RelativeTime-importable.client.web.********************.js 1.99 kB 0 B
dotcom-rendering/dist/RichLinkComponent-importable.client.web.********************.js 6.25 kB +45 B (+1%)
dotcom-rendering/dist/SecureSignup-importable.client.web.********************.js 3.63 kB +25 B (+1%)
dotcom-rendering/dist/SendAMessage-importable.client.web.********************.js 4.43 kB +33 B (+1%)
dotcom-rendering/dist/SendTargetingParams-importable.client.web.********************.js 2.11 kB 0 B
dotcom-rendering/dist/sentry.client.web.********************.js 786 B 0 B
dotcom-rendering/dist/SetABTests-importable.client.web.********************.js 3.42 kB 0 B
dotcom-rendering/dist/SetAdTargeting-importable.client.web.********************.js 485 B 0 B
dotcom-rendering/dist/shimport.client.web.********************.js 2.79 kB 0 B
dotcom-rendering/dist/ShowHideContainers-importable.client.web.********************.js 647 B 0 B
dotcom-rendering/dist/ShowMore-importable.client.web.********************.js 5.71 kB -1 B (0%)
dotcom-rendering/dist/SignInGateMain.client.web.********************.js 3.93 kB +22 B (+1%)
dotcom-rendering/dist/SignInGateMainCheckoutComplete.client.web.********************.js 5.04 kB +27 B (+1%)
dotcom-rendering/dist/SignInGateSelector-importable.client.web.********************.js 5.64 kB 0 B
dotcom-rendering/dist/SlotBodyEnd-importable.client.web.********************.js 6.84 kB +2 B (0%)
dotcom-rendering/dist/SpotifyBlockComponent-importable.client.web.********************.js 5.53 kB +26 B (0%)
dotcom-rendering/dist/StickyBottomBanner-importable.client.web.********************.js 5.38 kB -1 B (0%)
dotcom-rendering/dist/SubNav-importable.client.web.********************.js 2.25 kB 0 B
dotcom-rendering/dist/SupportTheG-importable.client.web.********************.js 5.91 kB 0 B
dotcom-rendering/dist/TableOfContents-importable.client.web.********************.js 3.17 kB +69 B (+2%)
dotcom-rendering/dist/TimelineAtom-importable.client.web.********************.js 1.24 kB 0 B
dotcom-rendering/dist/TweetBlockComponent-importable.client.web.********************.js 1.02 kB 0 B
dotcom-rendering/dist/UnsafeEmbedBlockComponent-importable.client.web.********************.js 3.71 kB +29 B (+1%)
dotcom-rendering/dist/VideoFacebookBlockComponent-importable.client.web.********************.js 5.7 kB +24 B (0%)
dotcom-rendering/dist/VineBlockComponent-importable.client.web.********************.js 3.54 kB +33 B (+1%)
dotcom-rendering/dist/WeatherWrapper-importable.client.web.********************.js 5.47 kB +23 B (0%)
dotcom-rendering/dist/YoutubeBlockComponent-importable.client.web.********************.js 3.97 kB +68 B (+2%)

compressed-size-action

@abeddow91 abeddow91 force-pushed the ab/bump-source-packages branch from 916ce8e to 037ed45 Compare February 19, 2024 15:39
@abeddow91 abeddow91 changed the title Ab/bump source packages Display max file size warning for callout file inputs Feb 19, 2024
@abeddow91 abeddow91 marked this pull request as ready for review February 19, 2024 15:50
@abeddow91 abeddow91 requested review from a team as code owners February 19, 2024 15:50
@abeddow91 abeddow91 removed the run_chromatic Runs chromatic when label is applied label Feb 19, 2024
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

Click here to see the Chromatic project.

@abeddow91 abeddow91 added the run_chromatic Runs chromatic when label is applied label Feb 19, 2024
Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but there are some failing actions

Copy link
Contributor

@cemms1 cemms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Chromatic might be failing due to this? https://status.chromatic.com/incident/329017

@abeddow91 abeddow91 force-pushed the ab/bump-source-packages branch from c5896d6 to da3a439 Compare February 20, 2024 09:17
@abeddow91 abeddow91 merged commit 2d099c4 into main Feb 20, 2024
29 checks passed
@abeddow91 abeddow91 deleted the ab/bump-source-packages branch February 20, 2024 10:28
@abeddow91 abeddow91 linked an issue Feb 20, 2024 that may be closed by this pull request
@prout-bot
Copy link

Seen on PROD (merged by @abeddow91 9 minutes and 57 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotcom-rendering run_chromatic Runs chromatic when label is applied Seen-on-PROD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callouts: Communicate file size upload limit to readers
4 participants