-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create stories for web ad slots #13143
Conversation
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Size Change: +5 B (0%) Total Size: 871 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! ✨ so neat!
As an additional extra, I wonder if we might want to include light and dark modes in the same story? There's a split theme decorator we could use for this
What does this change?
This adds stories for various DCR-rendered ad slots.
Why?
There have been some recent issues with visual regressions in ad styling- see #13111. Adding stories enables us to catch these early rather than relying on reports after the fact.