Passcodes | Release sign in with passcodes to all users #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldlink
added
the
passwordless
coldlink
force-pushed
the
mm/passcode-signin-100
branch
from
eef0e8d to
8077e93
Compare
coldlink
force-pushed
the
mm/passcode-signin-100
branch
from
8077e93 to
3524abe
Compare
coldlink
force-pushed
the
mm/passcode-signin-100
branch
from
3524abe to
de09457
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Releases passcodes for sign in to all of the audience following on from #3034
We also remove the AB test and the
usePasscodeSignInquery parameter which would've been needed in order to view the sign in with passcode page.We add a
usePasswordSignInquery parameter flag, which preserves the previous behaviour of sign in with a password directly on the initial sign in page. This is useful as it means tests can still continue to run without having to be integrated with passcodes for sign in.Tested