Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds temporary workaround for mink-selenium-driver #9

Closed
wants to merge 1 commit into from
Closed

Adds temporary workaround for mink-selenium-driver #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
],
"require": {
"php": ">=5.6",
"behat/mink-selenium2-driver": "dev-master as 1.3.x-dev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be in the "require-dev" section.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can move it, but from what I see in drupal-composer/drupal-project#511 (comment) has it in the require section.

Still move it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think so since it is a dev dependency in the first place.

minkphp/MinkSelenium2Driver#313 (comment)

I used "1.4.x-dev as 1.3.x-dev" locally to be able to work on a project.

Copy link
Contributor

@joestewart joestewart Sep 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR shouldn't be required now - https://packagist.org/packages/behat/mink-selenium2-driver#1.3.x-dev

minkphp/MinkSelenium2Driver#313 (comment)

"composer/installers": "^1.2",
"cweagans/composer-patches": "^1.6.5",
"drupal-composer/drupal-scaffold": "^2.5",
Expand Down