Fix loglikelihood_function
argument in nessai sampler
#4860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard information about the request
This is a: bug fix
This change affects: inference
This change changes: scientific output
This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
This change will: fix a bug that prevents an option from being used
Motivation
The current implementation does not allow the user to specify the
loglikelihood-function
. Instead it raises an error:Contents
This happens because the sampler class checks the specified options against a list of valid options but this did not account for the pycbc-specific option
loglikelihood-function
. This PR addsloglikelihood-function
to the set of options pycbc-specific options that are allowed.Links to any issues or associated PRs
N/A
Testing performed
I've run the LISA injection example with a modified config where
loglikelihood-function=loglr
Additional notes