-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting and Prettier formatting #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still some eslint warnings (mostly no-console) - should these lints be fixed or disabled?
I would say keep them as majority are for Tap to Pay or erroring. I'll remove them later on as I believe Tap to Pay is using a mock location id so I still want the debug. |
@thedev132 is there something more appropriate than console log we could be using? As for the mock location id, if we already have the function to be getting the user's location we should be using that. There are also a few other issues persisting such as on PaymentCard:82 |
@Luke-Oldenburg Would you prefer to use something like Sentry instead but idk how that would work as Sentry is more for crash reporting than debugging. Just fixed the useEffect warnings as they don't really change anything. As for location mock id it isn't appropriate for this PR. I'll make this change in it's own PR |
@thedev132 for now just disable the console log lints and then we can add Sentry to certain things in the future. |
@Luke-Oldenburg do you prefer removing them or commenting them out. I think commenting is better as we would know later where we should report |
@thedev132 neither; can you disable that lint rule? |
@Luke-Oldenburg ah ok yea I can disable the rule, misunderstood what you were saying. |
No description provided.