Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Long term fix for the new year data not in yet #1884

Open
4 tasks
DrAcula27 opened this issue Jan 7, 2025 · 3 comments
Open
4 tasks

ER: Long term fix for the new year data not in yet #1884

DrAcula27 opened this issue Jan 7, 2025 · 3 comments
Assignees
Labels
P-feature: Map Question Further information is requested ready for dev lead ready for developer lead to review the issue Role: Frontend React front end work size: 0.25pt Can be done in 1.5 hours

Comments

@DrAcula27
Copy link
Member

DrAcula27 commented Jan 7, 2025

Overview

We need to add logic to check for the previous year's data if the current year's data is not in yet to keep the map from not loading.

More Info

At the beginning of the year, we have a lack of data. The application looks for data from the database, but it isn't there yet, so it loads forever.

Proposed Action Items

  • Add a check to see if current year data exists.
    • If not, request the previous year's data, so the map can continue to load.
    • Change the date picker to show the last week of December.
    • Limit user to previous year via date picker.
@DrAcula27 DrAcula27 added this to the X - Technical Debt milestone Jan 7, 2025
@github-project-automation github-project-automation bot moved this to New Issue Approval in P: 311: Project Board Jan 7, 2025
@ryanfchase ryanfchase self-assigned this Jan 12, 2025
@efrenmarin45
Copy link
Member

Can we look into adding a modal disclaimer as well that populates in the new year when the data has not yet been uploaded? This way the user is aware that their queries would be confined to the previous year until the tool is updated with the new year.

@traycn
Copy link
Member

traycn commented Jan 14, 2025

@efrenmarin45 This is a great idea! Created a design: #1893 and dev: #1894 issue.

Once we have a design we'll be ready to assign the task to dev.

@ryanfchase ryanfchase moved this from New Issue Approval to In Review in P: 311: Project Board Jan 20, 2025
@ryanfchase ryanfchase changed the title Long term fix for the new year data not in yet (pls fix title) ER: Long term fix for the new year data not in yet Jan 20, 2025
@ryanfchase
Copy link
Member

I've retrofitted this ticket to be an ER, since it is acting as a discussion ticket relating to data that isn't available, and new tickets have been opened to address the issue.

About this ticket's proposed Action Items: do we have a consensus on behavior of the Datepicker when the 2025 data is not available? I'd like design's input to know if this user flow is okay. I now see why a separate modal/messaging may be necessary if the map does not load. I will make sure this Datepicker flow is addressed in the thread on #1893.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-feature: Map Question Further information is requested ready for dev lead ready for developer lead to review the issue Role: Frontend React front end work size: 0.25pt Can be done in 1.5 hours
Projects
Status: Questions
Development

No branches or pull requests

4 participants