HCK-9128: Handle indexes without name in Hive (#104)

* HCK-9128: Handle indexes without name * HCK-9128: Handle indexes without name
hackolade · Dec 16, 2024 · 5f4cdc0 · 5f4cdc0
1 parent b4d7ffb
commit 5f4cdc0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/forward_engineering/helpers/indexHelper.js b/forward_engineering/helpers/indexHelper.js
@@ -20,6 +20,10 @@ const getIndexStatement = ({
 	inTable,
 	isActivated,
 }) => {
+	if (!name.trim() || !columns) {
+		return '';
+	}
+
 	return buildStatement(
 		`CREATE INDEX ${name} ON TABLE ${dbName}.${tableName} (${columns}) AS '${indexHandler}'`,
 		isActivated,

diff --git a/properties_pane/entity_level/entityLevelConfig.json b/properties_pane/entity_level/entityLevelConfig.json
@@ -585,7 +585,10 @@ making sure that you maintain a proper JSON format.
 						"propertyKeyword": "name",
 						"propertyTooltip": "",
 						"propertyType": "text",
-						"defaultValue": "New Secondary Index"
+						"defaultValue": "",
+						"validation": {
+							"required": true
+						}
 					},
 					{
 						"propertyName": "Activated",
@@ -598,7 +601,11 @@ making sure that you maintain a proper JSON format.
 						"propertyName": "Key",
 						"propertyKeyword": "SecIndxKey",
 						"propertyType": "fieldList",
-						"template": "orderedList"
+						"template": "orderedList",
+						"validation": {
+							"minLength": 1,
+							"required": true
+						}
 					},
 					{
 						"propertyName": "Id",