Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCK-8971: include schema name in index name of DDL #35

Merged
merged 3 commits into from
Dec 4, 2024
Merged

HCK-8971: include schema name in index name of DDL #35

merged 3 commits into from
Dec 4, 2024

Conversation

Nightlngale
Copy link
Contributor

@Nightlngale Nightlngale commented Dec 4, 2024 •
edited by github-actions bot
Loading

Sub-taskHCK-8971 [BBVA] include schema name in index name of DDL

Content

  • Create index script includes schema name

@Nightlngale Nightlngale self-assigned this Dec 4, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

chulanovskyi-bs
chulanovskyi-bs reviewed Dec 4, 2024
View reviewed changes
forward_engineering/helpers/general.js Outdated
* @param {string} params.schemaName
* @returns {string}
* */
const getNamePrefixedWithSchemaName = ({name, schemaName}) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you applied the prettier? seems like there are spaces in brackets missing

chulanovskyi-bs
chulanovskyi-bs reviewed Dec 4, 2024
View reviewed changes
forward_engineering/helpers/general.js Outdated
* @returns {string}
*/
const getIndexName = ({ name, schemaName }) => {
return getNamePrefixedWithSchemaName({name, schemaName});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Nightlngale Nightlngale enabled auto-merge (squash) December 4, 2024 14:14
@chulanovskyi-bs chulanovskyi-bs merged commit 5096a56 into develop Dec 4, 2024
3 of 9 checks passed
@chulanovskyi-bs chulanovskyi-bs deleted the HCK-8971 branch December 4, 2024 15:06
Nightlngale added a commit that referenced this pull request Dec 5, 2024
@Nightlngale
Revert "HCK-8971: include schema name in index name of DDL (#35)"
fc3c5d3 
This reverts commit 5096a56.
chulanovskyi-bs pushed a commit that referenced this pull request Dec 5, 2024
@Nightlngale
Revert "HCK-8971: include schema name in index name of DDL (#35)" (#36)
0e072b6 
This reverts commit 5096a56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chulanovskyi-bs chulanovskyi-bs chulanovskyi-bs approved these changes

Assignees

@Nightlngale Nightlngale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nightlngale @chulanovskyi-bs