review feedback from cvittal

hail-is · Sep 16, 2024 · 992de5f · 992de5f
1 parent 68d1fa3
commit 992de5f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/hail/python/hail/expr/expressions/expression_utils.py b/hail/python/hail/expr/expressions/expression_utils.py
@@ -162,7 +162,7 @@ def eval_timed(expression):
         ir = expression._indices.source.select_globals(**{uid: expression}).index_globals()[uid]._ir
 
     (value, timings) = Env.backend().execute(MakeTuple([ir]), timed=True)
-    return (value[0], timings)
+    return value[0], timings
 
 
 @typecheck(expression=expr_any)

diff --git a/hail/src/main/scala/is/hail/backend/ExecuteContext.scala b/hail/src/main/scala/is/hail/backend/ExecuteContext.scala
@@ -17,7 +17,7 @@ import java.security.SecureRandom
 import sourcecode.Enclosing
 
 trait TempFileManager extends AutoCloseable {
-  def newTmpPath(tmpdir: String, prefix: String, extension: String = ""): String
+  def newTmpPath(tmpdir: String, prefix: String, extension: String = null): String
 }
 
 class OwningTempFileManager(fs: FS) extends TempFileManager {

diff --git a/hail/src/main/scala/is/hail/expr/ir/lowering/LoweringPass.scala b/hail/src/main/scala/is/hail/expr/ir/lowering/LoweringPass.scala
@@ -26,7 +26,7 @@ trait LoweringPass {
   val after: IRState
   val context: String
 
-  final def apply(ctx: ExecuteContext, ir: BaseIR): BaseIR = {
+  final def apply(cqtx: ExecuteContext, ir: BaseIR): BaseIR = {
     ctx.timer.time(context) {
       ctx.timer.time("Verify")(before.verify(ir))
       val result = ctx.timer.time("Transform")(transform(ctx, ir))
@@ -39,10 +39,10 @@ trait LoweringPass {
 }
 
 case class OptimizePass(_context: String) extends LoweringPass {
-  val context = s"Optimize: ${_context}"
-  val before: IRState = AnyIR
-  val after: IRState = AnyIR
-  def transform(ctx: ExecuteContext, ir: BaseIR): BaseIR = Optimize(ctx, ir)
+  override val context = s"Optimize: ${_context}"
+  override val before: IRState = AnyIR
+  override val after: IRState = AnyIR
+  override def transform(ctx: ExecuteContext, ir: BaseIR): BaseIR = Optimize(ctx, ir)
 }
 
 case object LowerMatrixToTablePass extends LoweringPass {