mill update #14769
Merged
mill update #14769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
patrick-schultz
force-pushed
the
ps-12-16-mill_update
branch
from
82a5357 to
fbf771a
Compare
ehigham
reviewed
Dec 17, 2024
1 task
patrick-schultz
force-pushed
the
ps-12-16-mill_update
branch
2 times, most recently
from
dcc28c1 to
728ff17
Compare
ehigham
approved these changes
Dec 17, 2024
patrick-schultz
force-pushed
the
ps-12-16-mill_update
branch
from
728ff17 to
8c5873b
Compare
chrisvittal
approved these changes
Dec 17, 2024
|
It seemed to be the scala upgrade adding new warnings, particularly for semantic disagreements between 2.x and 3.x, and we have fatal warnings on. |
patrick-schultz
force-pushed
the
ps-12-16-mill_update
branch
3 times, most recently
from
8d105cf to
2b10d49
Compare
ehigham
force-pushed
the
ps-12-16-mill_update
branch
from
2b10d49 to
d35b0d5
Compare
patrick-schultz
force-pushed
the
ps-12-16-mill_update
branch
from
d35b0d5 to
2b10d49
Compare
patrick-schultz
force-pushed
the
ps-12-16-mill_update
branch
from
2b10d49 to
c61d0a8
Compare
grohli
pushed a commit
to grohli/hail
that referenced
this pull request
Jan 27, 2025
## Change Description Update mill to 0.12.4. Modify the build script to use the new `build.mill` style, and to move top level tasks into the root module. Also needed to update scala from 2.12.15 to 2.12.20, for compatibility with the semanticdb compiler plugin used by scalafix. ## Security Assessment - This change has no security impact ### Impact Description Small refactoring of the build system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Update mill to 0.12.4. Modify the build script to use the new
build.millstyle, and to move top level tasks into the root module.Also needed to update scala from 2.12.15 to 2.12.20, for compatibility with the semanticdb compiler plugin used by scalafix.
Security Assessment
Impact Description
Small refactoring of the build system.