Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] don't hardcode paths to test resources, cont'd #14779

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

patrick-schultz
Copy link
Collaborator

@patrick-schultz patrick-schultz commented Jan 9, 2025

Change Description

#14775 missed some places in the scala tests where the test resources directory is hardcoded. This fixes the remaining cases.

Security Assessment

Delete all except the correct answer:

  • This change has no security impact

Impact Description

Tests-only change

(Reviewers: please confirm the security impact before approving)

Copy link
Collaborator Author

patrick-schultz commented Jan 9, 2025

@patrick-schultz patrick-schultz marked this pull request as ready for review January 9, 2025 20:01
@patrick-schultz patrick-schultz changed the title don't hardcode paths to test resources, cont'd [query] don't hardcode paths to test resources, cont'd Jan 9, 2025
Copy link
Contributor

@grohli grohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@cjllanwarne cjllanwarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates all look correct 👍

@hail-ci-robot hail-ci-robot merged commit 1d12887 into main Jan 17, 2025
4 checks passed
@hail-ci-robot hail-ci-robot deleted the ps/hardcoded-paths2 branch January 17, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants