Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cluster output select dropdown should show meaningful sentence if no options available #1270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

houhoucoop
Copy link

@houhoucoop houhoucoop commented Jan 20, 2025

Summary

Display the corresponding message if no matching options are found.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #7305

Occurred changes and/or fixed issues

Add condition this.isSearchable to function showTagPrompts

Areas or cases that should be tested

Go to Rancher
Go to Virtualization Management -> Harvester cluster -> Virtual Machines
Click on Console button

  • Go to Logging -> Cluster Flows
  • Click Create button and click second tab Outputs
  • Click the Cluster Outputs options, it should show Sorry, no matching options.
  • Same behavior to create Flows

Screenshot/Video

Screenshot 2025-01-20 at 1 35 49 PM (2)
Screenshot 2025-01-20 at 1 48 17 PM (2)

Signed-off-by: Yi-Ya Chen <yiya.chen@suse.com>
@a110605
Copy link
Collaborator

a110605 commented Jan 20, 2025

As harvester/harvester#7305 is targeting v1.4.2.
Remember to hold on the backport PR until v1.4.1 is released. (you can add DO_NOT_MERGED label for backport PR)

Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants