Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check image name length in preflight phase #56

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Check image name length in preflight phase #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e279a64
Enhance importer to handle several issue
votdev Sep 9, 2024
f5cea3e
Check image name length in preflight phase
votdev Oct 28, 2024
99bb135
Fix networking
votdev Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions pkg/apis/migration.harvesterhci.io/v1beta1/virtualmachines.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,18 @@ type VirtualMachineImport struct {

// VirtualMachineImportSpec is used to create kubevirt VirtualMachines by exporting VM's from migration clusters.
type VirtualMachineImportSpec struct {
SourceCluster corev1.ObjectReference `json:"sourceCluster"`
VirtualMachineName string `json:"virtualMachineName"`
Folder string `json:"folder,omitempty"`
Mapping []NetworkMapping `json:"networkMapping,omitempty"` //If empty new VirtualMachineImport will be mapped to Management Network
StorageClass string `json:"storageClass,omitempty"`
SourceCluster corev1.ObjectReference `json:"sourceCluster"`

// VirtualMachineName is the name of the virtual machine that will be
// imported. It contains the name or ID of the source virtual machine.
// Note that these names may not be DNS1123 compliant and will therefore
// be sanitized later.
// Examples: "vm-1234", "my-VM" or "5649cac7-3871-4bb5-aab6-c72b8c18d0a2"
VirtualMachineName string `json:"virtualMachineName"`

Folder string `json:"folder,omitempty"`
Mapping []NetworkMapping `json:"networkMapping,omitempty"` //If empty new VirtualMachineImport will be mapped to Management Network
StorageClass string `json:"storageClass,omitempty"`
}

// VirtualMachineImportStatus tracks the status of the VirtualMachineImport export from migration and import into the Harvester cluster
Expand All @@ -34,6 +41,11 @@ type VirtualMachineImportStatus struct {
DiskImportStatus []DiskInfo `json:"diskImportStatus,omitempty"`
ImportConditions []common.Condition `json:"importConditions,omitempty"`
NewVirtualMachine string `json:"newVirtualMachine,omitempty"`

// DefiniteVirtualMachineName is the sanitized and definite name of the
// target virtual machine that will be created in the Harvester cluster.
// The name is DNS1123 compliant.
DefiniteVirtualMachineName string `json:"definiteVirtualMachineName,omitempty"`
}

// DiskInfo contains the information about associated Disk in the Import migration.
Expand Down Expand Up @@ -70,14 +82,14 @@ const (
DiskImagesFailed ImportStatus = "diskImageFailed"
VirtualMachineCreated ImportStatus = "virtualMachineCreated"
VirtualMachineRunning ImportStatus = "virtualMachineRunning"
VirtualMachineInvalid ImportStatus = "virtualMachineInvalid"
VirtualMachineImportValid ImportStatus = "virtualMachineImportValid"
VirtualMachineImportInvalid ImportStatus = "virtualMachineImportInvalid"
VirtualMachinePoweringOff condition.Cond = "VMPoweringOff"
VirtualMachinePoweredOff condition.Cond = "VMPoweredOff"
VirtualMachineExported condition.Cond = "VMExported"
VirtualMachineImageSubmitted condition.Cond = "VirtualMachineImageSubmitted"
VirtualMachineImageReady condition.Cond = "VirtualMachineImageReady"
VirtualMachineImageFailed condition.Cond = "VirtualMachineImageFailed"
NotValidDNS1123Label string = "not a valid DNS1123 label"
VirtualMachineExportFailed condition.Cond = "VMExportFailed"
VirtualMachineMigrationFailed ImportStatus = "VMMigrationFailed"
)
20 changes: 11 additions & 9 deletions pkg/controllers/migration/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func (h *virtualMachineHandler) reconcileDiskImageStatus(vm *migration.VirtualMa
// If VM has no disks associated ignore the VM
if len(orgStatus.DiskImportStatus) == 0 {
logrus.Errorf("Imported VM %s in namespace %s, has no disks, being marked as invalid and will be ignored", vm.Name, vm.Namespace)
vm.Status.Status = migration.VirtualMachineInvalid
vm.Status.Status = migration.VirtualMachineImportInvalid
return h.importVM.UpdateStatus(vm)

}
Expand Down Expand Up @@ -86,8 +86,8 @@ func (h *virtualMachineHandler) reconcileVirtualMachineStatus(vm *migration.Virt
return vm, err
}
if !ok {
// VM not running, requeue and check after 5mins
h.importVM.EnqueueAfter(vm.Namespace, vm.Name, 5*time.Minute)
// VM not running, requeue and check after 2mins
h.importVM.EnqueueAfter(vm.Namespace, vm.Name, 2*time.Minute)
return vm, nil
}

Expand All @@ -98,13 +98,15 @@ func (h *virtualMachineHandler) reconcileVirtualMachineStatus(vm *migration.Virt
func (h *virtualMachineHandler) reconcilePreFlightChecks(vm *migration.VirtualMachineImport) (*migration.VirtualMachineImport, error) {
err := h.preFlightChecks(vm)
if err != nil {
if err.Error() != migration.NotValidDNS1123Label {
return vm, err
}
logrus.Errorf("vm migration target %s in VM %s in namespace %s is not RFC 1123 compliant", vm.Spec.VirtualMachineName, vm.Name, vm.Namespace)
vm.Status.Status = migration.VirtualMachineInvalid
logrus.WithFields(logrus.Fields{
"name": vm.Name,
"namespace": vm.Namespace,
"spec.virtualMachineName": vm.Spec.VirtualMachineName,
}).Errorf("The preflight checks failed: %v", err)
// Stop the reconciling for good as the checks failed.
vm.Status.Status = migration.VirtualMachineImportInvalid
} else {
vm.Status.Status = migration.SourceReady
vm.Status.Status = migration.VirtualMachineImportValid
}
return h.importVM.UpdateStatus(vm)
}
Expand Down
8 changes: 5 additions & 3 deletions pkg/controllers/migration/openstack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func RegisterOpenstackController(ctx context.Context, os migrationController.Ope
os.OnChange(ctx, "openstack-migration-change", oHandler.OnSourceChange)
}

func (h *openstackHandler) OnSourceChange(_ string, o *migration.OpenstackSource) (*migration.OpenstackSource, error) {
func (h *openstackHandler) OnSourceChange(key string, o *migration.OpenstackSource) (*migration.OpenstackSource, error) {
if o == nil || o.DeletionTimestamp != nil {
return o, nil
}
Expand All @@ -42,7 +42,9 @@ func (h *openstackHandler) OnSourceChange(_ string, o *migration.OpenstackSource
"kind": o.Kind,
"name": o.Name,
"namespace": o.Namespace,
}).Info("Reconciling migration source")
"key": key,
}).Info("Reconciling source")

if o.Status.Status != migration.ClusterReady {
// process migration logic
secretObj, err := h.secret.Get(o.Spec.Credentials.Namespace, o.Spec.Credentials.Name, metav1.GetOptions{})
Expand All @@ -52,7 +54,7 @@ func (h *openstackHandler) OnSourceChange(_ string, o *migration.OpenstackSource

client, err := openstack.NewClient(h.ctx, o.Spec.EndpointAddress, o.Spec.Region, secretObj)
if err != nil {
return o, fmt.Errorf("error generating openstack client for openstack migration: %s: %v", o.Name, err)
return o, fmt.Errorf("error generating openstack client for openstack migration '%s': %v", o.Name, err)
}

err = client.Verify()
Expand Down
Loading
Loading