Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve CRD template field insertion line targeting #4268

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improve CRD template field insertion line targeting #4268

wants to merge 1 commit into from

Conversation

zalimeni
Copy link
Member

@zalimeni zalimeni commented Aug 28, 2024 •
edited
Loading

Match YAML elements instead of blindly matching line numbers.

@zalimeni zalimeni requested a review from ndhanushkodi August 28, 2024 12:33
Base automatically changed from nd/net-10435-cluster-validation-1.1.x to release/1.1.x August 28, 2024 19:51
@zalimeni zalimeni changed the base branch from release/1.1.x to main August 28, 2024 19:56
@zalimeni zalimeni requested a review from a team as a code owner August 28, 2024 19:56
@zalimeni zalimeni force-pushed the zalimeni/fix-hack/nd/net-10435-cluster-validation-1.1.x branch from daca3bc to fdc965c Compare August 28, 2024 19:57
@zalimeni zalimeni force-pushed the zalimeni/fix-hack/nd/net-10435-cluster-validation-1.1.x branch from fdc965c to 725da74 Compare August 28, 2024 19:58
@zalimeni zalimeni added backport/1.1.x Backport to release/1.1.x branch backport/1.3.x This release branch is no longer active. backport/1.4.x backport/1.5.x pr/no-changelog PR does not need a corresponding .changelog entry labels Aug 28, 2024
@zalimeni zalimeni requested review from jmurret and dhiaayachi August 29, 2024 18:13
ndhanushkodi
ndhanushkodi approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thanks for making this change!!

@zalimeni zalimeni enabled auto-merge (squash) September 18, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

@jmurret jmurret Awaiting requested review from jmurret

@dhiaayachi dhiaayachi Awaiting requested review from dhiaayachi

Assignees
No one assigned
Labels
backport/1.1.x Backport to release/1.1.x branch backport/1.3.x This release branch is no longer active. backport/1.4.x backport/1.5.x pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zalimeni @ndhanushkodi