Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improvements to support generated data plane SDKs #1058

Merged
merged 2 commits into from
Aug 15, 2024
Merged

refactor: improvements to support generated data plane SDKs #1058

merged 2 commits into from
Aug 15, 2024

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Aug 5, 2024 •
edited
Loading

  • Add support for nullable model field types
  • Make it possible to reuse clients by aligning the constructor function names

Required for hashicorp/pandora#4346

@manicminer manicminer requested a review from a team as a code owner August 5, 2024 19:00
@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Aug 5, 2024
@manicminer manicminer mentioned this pull request Aug 5, 2024
Merged
3 tasks
@manicminer manicminer changed the title refactor: make it possible to reuse clients by aligning the constructor function names refactor: improvements to support generated data plane SDKs Aug 11, 2024
@manicminer manicminer force-pushed the refactor/client-reuse branch 3 times, most recently from 1907966 to 4acafc4 Compare August 12, 2024 19:22
@manicminer manicminer force-pushed the refactor/client-reuse branch from 4acafc4 to 04f20bf Compare August 12, 2024 19:34
stephybun
stephybun approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manicminer LGTM 👍

@manicminer manicminer merged commit 297738c into main Aug 15, 2024
5 checks passed
@manicminer manicminer deleted the refactor/client-reuse branch August 15, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
base-layer release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @stephybun