handle empty nextlink value as end of pagination
#1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release-once-merged
ziyeqf
force-pushed
the
next_page_empty_string
branch
from
7094cab to
b2b361e
Compare
ziyeqf
force-pushed
the
next_page_empty_string
branch
from
351395b to
a8eb029
Compare
jackofallops
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks @ziyeqf - Sorry for the delay, lots of moving parts and PTO on the team held this one up. This LGTM 👍
jackofallops
changed the title
nextlink value as end of pagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chaosreturn an empty string in theNextLinkproperty instead of set it tonullwhen callingTargetTypes_List. It will make the provider wait endless...
I have opened an issue on azure-rest-api-specs repo, but can we consider add this workaround to avoid similar bad cases?