Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add App Configuration to environment #720

Merged

Conversation

TZdybel
Copy link
Contributor

@TZdybel TZdybel commented Nov 7, 2023

@TZdybel TZdybel requested a review from a team as a code owner November 7, 2023 08:44
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @TZdybel

Thanks for this PR - I've taken a look through and left one comment inline, but if we can fix that up then this otherwise LGTM 👍

sdk/environments/helpers.go Outdated Show resolved Hide resolved
TZdybel and others added 2 commits November 7, 2023 10:31
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 6d6d662 into hashicorp:main Nov 7, 2023
4 checks passed
@TZdybel TZdybel deleted the add_app_configuration_to_environment branch November 7, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants