Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block_device doc: Fix supported volume types #209

Conversation

runephilosof-karnovgroup

The documentation lists the supported volume types with _, but it should be -.

@runephilosof-karnovgroup runephilosof-karnovgroup requested a review from a team as a code owner February 8, 2024 10:54
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @runephilosof-karnovgroup,

Thanks for this fix, this looks good to me; may I ask you to sign our CLAs before we merge this, as we won't be able to because of legal constraints otherwise.

Also since you changed the documentation for this attribute, could you regenerate the doc partials from it? Running make generate should be enough to have it all up-to-date.

Thanks!

@runephilosof-karnovgroup
Copy link
Author

Sorry, I won't sign the CLA (too much effort required to get that approved, for this tiny contribution).
It was just easier to create a PR than describe it in an issue.

@runephilosof-karnovgroup
Copy link
Author

Converted to an issue #219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants