Skip to content

Commit

Permalink
Merge pull request #3600 from hashicorp/f/disabling-the-generation-of…
Browse files Browse the repository at this point in the history
…-v1-api-definitions

`tools/importer-rest-api-specs`: disabling the generation of the V1 API Definitions
  • Loading branch information
tombuildsstuff authored Jan 11, 2024
2 parents 64fc5d1 + a97b134 commit 4332075
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 39 deletions.
29 changes: 0 additions & 29 deletions .github/workflows/automation-extract-tf-resource-ids.yaml

This file was deleted.

11 changes: 2 additions & 9 deletions tools/importer-rest-api-specs/GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,14 @@ import: build
else \
./importer-rest-api-specs import -services=$(SERVICES); \
fi
# note we're intentionally only using whitespace here since the others try
# to fix design issues, which are actually issues in the API Data
dotnet format whitespace --verbosity quiet ../../data/Pandora.sln

import-with-api: build
./importer-rest-api-specs import --data-api=http://localhost:5000
# note we're intentionally only using whitespace here since the others try
# to fix design issues, which are actually issues in the API Data
dotnet format whitespace --verbosity quiet ../../data/Pandora.sln
./importer-rest-api-specs import --data-api=http://localhost:8080

test: build
go test -v ./... -timeout=60m

tools:
@echo "==> installing required tooling..."
dotnet tool install -g dotnet-format
@echo "==> no tools required..."

.PHONY: build fmt import import-with-api test tools
2 changes: 1 addition & 1 deletion tools/importer-rest-api-specs/featureflags/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ package featureflags
const AllowConstantsWithoutXMSEnum = true

// GenerateV1APIDefinitions specifies whether the V1 (C#) API Definitions should be output.
const GenerateV1APIDefinitions = true
const GenerateV1APIDefinitions = false

// GenerateV2APIDefinitions specifies whether the V2 (JSON) API Definitions should be output.
const GenerateV2APIDefinitions = true

0 comments on commit 4332075

Please sign in to comment.