Merge pull request #3428 from hashicorp/data-api-v2-github-action

dataapiv2 - Add github actions to dataapiv2

.github/workflows/unit-test-data-api-v2.yaml

@@ -0,0 +1,27 @@
+---
+name: Verify Data API V2 API Definitions Can be Mapped
+on:
+  pull_request:
+    types: ['opened', 'synchronize']
+    paths:
+      - '.github/workflows/**'
+      - 'tools/data-api/**'
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+    steps:
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        with:
+         submodules: recursive
+
+      - uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
+        with:
+          go-version: '1.21.3'
+
+      - name: run unit tests
+        run: |
+          cd ./tools/data-api
+          make test

tools/data-api/GNUmakefile

@@ -9,4 +9,7 @@ fmt:
 run: build
 	./data-api serve
 
+test: build
+	go test -v ./...
+
 .PHONY: build fmt run

tools/data-api/internal/endpoints/v1/mappings.go

@@ -80,7 +80,7 @@ func mapDateFormat(input *repositories.DateFormat) (*models.DateFormat, error) {
 		if v, ok := mappings[*input]; ok {
 			return &v, nil
 		}
-		return nil, fmt.Errorf("unmapped date format %q", input)
+		return nil, fmt.Errorf("unmapped date format %+v", input)
 	}
 
 	return nil, nil

tools/data-api/internal/repositories/services_test.go

@@ -0,0 +1,27 @@
+package repositories
+
+import (
+	"testing"
+)
+
+func TestServices_ResourceManager(t *testing.T) {
+	repo, err := NewServicesRepository("../../../../api-definitions/", ResourceManagerServiceType, nil)
+	if err != nil {
+		t.Fatalf(err.Error())
+	}
+
+	if _, err := repo.GetAll(ResourceManagerServiceType); err != nil {
+		t.Fatalf(err.Error())
+	}
+}
+
+func TestServices_MicrosoftGraph(t *testing.T) {
+	repo, err := NewServicesRepository("../../../../api-definitions/", MicrosoftGraphV1StableServiceType, nil)
+	if err != nil {
+		t.Fatalf(err.Error())
+	}
+
+	if _, err := repo.GetAll(MicrosoftGraphV1StableServiceType); err != nil {
+		t.Fatalf(err.Error())
+	}
+}

tools/data-api/internal/repositories/validation.go

@@ -19,7 +19,7 @@ func validateModels(input map[string]ModelDetails, constants map[string]Constant
 
 			parentModel, ok := input[*modelDetail.ParentTypeName]
 			if !ok {
-				return fmt.Errorf("model %q: discriminated parent type model %q not found", *modelDetail.ParentTypeName)
+				return fmt.Errorf("model %q: discriminated parent type model %q not found", modelName, *modelDetail.ParentTypeName)
 			}
 
 			typeHintIn := ""