r/aws_sesv2_configuration_set_event_destination: Retry IAM eventual consistency errors

[kamilturek]

Description

This PR adds retries for IAM eventual consistency errors when creating or updating the aws_sesv2_configuration_set_event_destination resource.

Relations

Closes #33367.

References

https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_CreateConfigurationSetEventDestination.html
https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_UpdateConfigurationSetEventDestination.html

Output from Acceptance Testing

% make testacc PKG=sesv2 ACCTEST_PARALLELISM=1 TESTARGS="-run=TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/sesv2/... -v -count 1 -parallel 1  -run=TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination -timeout 360m
2025/01/08 23:07:31 Initializing Terraform AWS Provider...
=== RUN   TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== CONT  TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination (114.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      120.114s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSESV2ConfigurationSetEventDestination_' PKG=sesv2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/sesv2/... -v -count 1 -parallel 3  -run=TestAccSESV2ConfigurationSetEventDestination_ -timeout 360m
2025/01/09 08:45:16 Initializing Terraform AWS Provider...
=== RUN   TestAccSESV2ConfigurationSetEventDestination_basic
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_basic
=== RUN   TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_snsDestination
=== RUN   TestAccSESV2ConfigurationSetEventDestination_disappears
=== PAUSE TestAccSESV2ConfigurationSetEventDestination_disappears
=== CONT  TestAccSESV2ConfigurationSetEventDestination_basic
=== CONT  TestAccSESV2ConfigurationSetEventDestination_pinpointDestination
=== CONT  TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_eventBridgeDestination (14.11s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_disappears
--- PASS: TestAccSESV2ConfigurationSetEventDestination_basic (20.87s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_pinpointDestination (22.90s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_disappears (10.48s)
=== CONT  TestAccSESV2ConfigurationSetEventDestination_snsDestination
--- PASS: TestAccSESV2ConfigurationSetEventDestination_cloudWatchDestination (19.85s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_snsDestination (22.45s)
--- PASS: TestAccSESV2ConfigurationSetEventDestination_kinesisFirehoseDestination (120.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	146.448s

[ewbankkit]

@kamilturek Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!