implemented pr feedback to split CreateUpdate into create and update

hashicorp · Feb 21, 2024 · 2c9bd6a · 2c9bd6a
1 parent 44476ef
commit 2c9bd6a
Showing 1 changed file with 35 additions and 3 deletions.
diff --git a/internal/services/apimanagement/api_management_policy_fragment_resource.go b/internal/services/apimanagement/api_management_policy_fragment_resource.go
@@ -23,9 +23,9 @@ import (
 
 func resourceApiManagementPolicyFragment() *pluginsdk.Resource {
 	return &pluginsdk.Resource{
-		Create: resourceApiManagementPolicyFragmentCreateUpdate,
+		Create: resourceApiManagementPolicyFragmentCreate,
 		Read:   resourceApiManagementPolicyFragmentRead,
-		Update: resourceApiManagementPolicyFragmentCreateUpdate,
+		Update: resourceApiManagementPolicyFragmentUpdate,
 		Delete: resourceApiManagementPolicyFragmentDelete,
 		Importer: pluginsdk.ImporterValidatingResourceIdThen(func(id string) error {
 			_, err := policyfragment.ParsePolicyFragmentIDInsensitively(id)
@@ -93,7 +93,7 @@ func resourceApiManagementPolicyFragment() *pluginsdk.Resource {
 	}
 }
 
-func resourceApiManagementPolicyFragmentCreateUpdate(d *pluginsdk.ResourceData, meta interface{}) error {
+func resourceApiManagementPolicyFragmentCreate(d *pluginsdk.ResourceData, meta interface{}) error {
 	client := meta.(*clients.Client).ApiManagement.PolicyFragmentClient
 	ctx, cancel := timeouts.ForCreateUpdate(meta.(*clients.Client).StopContext, d)
 	subscriptionId := meta.(*clients.Client).Account.SubscriptionId
@@ -136,6 +136,38 @@ func resourceApiManagementPolicyFragmentCreateUpdate(d *pluginsdk.ResourceData,
 	return resourceApiManagementPolicyFragmentRead(d, meta)
 }
 
+func resourceApiManagementPolicyFragmentUpdate(d *pluginsdk.ResourceData, meta interface{}) error {
+	client := meta.(*clients.Client).ApiManagement.PolicyFragmentClient
+	ctx, cancel := timeouts.ForCreateUpdate(meta.(*clients.Client).StopContext, d)
+	defer cancel()
+
+	id, err := policyfragment.ParsePolicyFragmentIDInsensitively(d.Get("id").(string))
+	if err != nil {
+		return err
+	}
+
+	format := policyfragment.PolicyFragmentContentFormat(d.Get("format").(string))
+
+	description := d.Get("description").(string)
+	value := d.Get("value").(string)
+
+	parameters := policyfragment.PolicyFragmentContract{
+		Properties: &policyfragment.PolicyFragmentContractProperties{
+			Description: pointer.To(description),
+			Format:      pointer.To(format),
+			Value:       value,
+		},
+	}
+
+	if err := client.CreateOrUpdateThenPoll(ctx, pointer.From(id), parameters, policyfragment.CreateOrUpdateOperationOptions{}); err != nil {
+		return fmt.Errorf("creating/updating %s: %+v", id, err)
+	}
+
+	d.SetId(id.ID())
+
+	return resourceApiManagementPolicyFragmentRead(d, meta)
+}
+
 func resourceApiManagementPolicyFragmentRead(d *pluginsdk.ResourceData, meta interface{}) error {
 	client := meta.(*clients.Client).ApiManagement.PolicyFragmentClient
 	ctx, cancel := timeouts.ForRead(meta.(*clients.Client).StopContext, d)