fixed broken tests

hashicorp · Jan 14, 2025 · 9530778 · 9530778
1 parent 44d808e
commit 9530778
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/internal/provider/provider_schema_test.go b/internal/provider/provider_schema_test.go
@@ -160,6 +160,10 @@ func TestResourcesHaveEnabledFieldsMarkedAsBooleans(t *testing.T) {
 	// TODO: 4.0 - work through this list
 	resourceFieldsWhichNeedToBeAddressed := map[string]map[string]struct{}{
 		// 1: Fields which require renaming etc
+		"azurerm_datadog_monitor_sso_configuration": {
+			// should be fixed in 4.0, presumably ditching `_enabled` and adding Enum validation
+			"single_sign_on_enabled": {},
+		},
 		"azurerm_netapp_volume": {
 			// should be fixed in 4.0, presumably ditching `_enabled` and making this `protocols_to_use` or something?
 			"protocols_enabled": {},

diff --git a/internal/services/servicebus/servicebus_namespace_disaster_recovery_config_data_source.go b/internal/services/servicebus/servicebus_namespace_disaster_recovery_config_data_source.go
@@ -35,7 +35,6 @@ func dataSourceServiceBusNamespaceDisasterRecoveryConfig() *pluginsdk.Resource {
 				Type:         pluginsdk.TypeString,
 				Optional:     true,
 				ValidateFunc: namespaces.ValidateNamespaceID,
-				AtLeastOneOf: []string{"namespace_id", "resource_group_name", "namespace_name"},
 			},
 
 			"alias_authorization_rule_id": {

diff --git a/internal/services/servicebus/servicebus_queue_data_source.go b/internal/services/servicebus/servicebus_queue_data_source.go
@@ -36,7 +36,6 @@ func dataSourceServiceBusQueue() *pluginsdk.Resource {
 				Type:         pluginsdk.TypeString,
 				Optional:     true,
 				ValidateFunc: namespaces.ValidateNamespaceID,
-				AtLeastOneOf: []string{"namespace_id", "resource_group_name", "namespace_name"},
 			},
 
 			"auto_delete_on_idle": {

diff --git a/internal/services/servicebus/servicebus_subscription_data_source.go b/internal/services/servicebus/servicebus_subscription_data_source.go
@@ -33,7 +33,6 @@ func dataSourceServiceBusSubscription() *pluginsdk.Resource {
 				Type:         pluginsdk.TypeString,
 				Optional:     true,
 				ValidateFunc: topics.ValidateTopicID,
-				AtLeastOneOf: []string{"topic_id", "resource_group_name", "namespace_name", "topic_name"},
 			},
 
 			"auto_delete_on_idle": {