Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_private_dns_zone_virtual_network_link - explicit test for cross-tenant usage #23420

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Sep 28, 2023

Depends on: hashicorp/go-azure-sdk#665
Note: Requires rebase to remove first commit

This adds a test for cross-tenant usage of azurerm_private_dns_zone_virtual_network_link to help prevent regression. Upstream PR needs merging/releasing and adopting prior to merge.

TeamCity has been configured with the necessary variables.

Resolves: #23238

@manicminer manicminer added tests sdk/requires-upgrade This is dependent upon upgrading an SDK upstream/go-azure-sdk This issue/PR requires a fix in `hashicorp/go-azure-sdk` labels Sep 28, 2023
@manicminer
Copy link
Contributor Author

Test results

Screenshot 2023-09-29 at 00 00 01

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katbyte katbyte merged commit 376b671 into main Nov 24, 2023
21 checks passed
@katbyte katbyte deleted the tests/private-dns-zone-cross-tenant-net-link branch November 24, 2023 08:54
@github-actions github-actions bot added this to the v3.83.0 milestone Nov 24, 2023
@manicminer manicminer modified the milestones: v3.83.0, v3.82.0 Nov 27, 2023
Copy link

github-actions bot commented May 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sdk/requires-upgrade This is dependent upon upgrading an SDK service/dns size/M tests upstream/go-azure-sdk This issue/PR requires a fix in `hashicorp/go-azure-sdk`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private DNS Zone Virtual Network Link - Creation fails for cross-tenant
3 participants