Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_service_plan - Support premium_site_elastic_scaling_enabled feature. #24770

Closed
wants to merge 21 commits into from

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Feb 4, 2024

Azure currently allows user to set the automatic scaling for premium v2 and v3 service plan, more detailed feature intro:https://learn.microsoft.com/en-us/azure/app-service/manage-automatic-scaling?tabs=azure-portal

MS 100% coverage task.

Acc tests:
--- PASS: TestAccServicePlan_premiumElasticScaling (154.22s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice 160.882s

The property is not designed for elastic plan, the value is always true and cannot be turned to false, as user is not able to set the property, remove from the state for elastic plan.

The failed CI doesn't relate to the code changed in this PR.

Failed acc tests are not related to the code change in this PR:
image

@xiaxyi xiaxyi marked this pull request as draft February 21, 2024 09:47
@xiaxyi xiaxyi marked this pull request as ready for review February 22, 2024 02:20
@jackofallops
Copy link
Member

Closing due to conflicts, breaking change status and long open time. This can be re-opened when the issues/conflicts are resolved and is ready for re-review.

Copy link

github-actions bot commented Jul 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants