azurerm_mysql_* - deprecate Mysql Single Server and its sub resources
#25187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-yechenwei
changed the title
azurerm_mysql_server - deprecate this resourceazurerm_mysql_* - deprecate Mysql Single Server
neil-yechenwei
changed the title
azurerm_mysql_* - deprecate Mysql Single Serverazurerm_mysql_* - deprecate Mysql Single Server and its sub resources
stephybun
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Thanks @neil-yechenwei. I left a suggestion on the phrasing of the deprecation message, could you please apply those changes to the rest of the deprecation messages?
| @@ -25,6 +25,9 @@ func resourceMySQLAdministrator() *pluginsdk.Resource { | |||
| Read: resourceMySQLAdministratorRead, | |||
| Update: resourceMySQLAdministratorCreateUpdate, | |||
| Delete: resourceMySQLAdministratorDelete, | |||
|
|
|||
| DeprecationMessage: "The `azurerm_mysql_active_directory_administrator` resource will be deprecated since Azure Database for MySQL - Single Server and its sub resources are scheduled for retirement (https://go.microsoft.com/fwlink/?linkid=2216041) by September 16, 2024 and they migrate (https://go.microsoft.com/fwlink/?linkid=2202255) to Azure Database for MySQL - Flexible Server and its sub resources now. Please use the `azurerm_mysql_flexible_server_active_directory_administrator` resource instead.", | |||
There was a problem hiding this comment.
Suggested change
| DeprecationMessage: "The `azurerm_mysql_active_directory_administrator` resource will be deprecated since Azure Database for MySQL - Single Server and its sub resources are scheduled for retirement (https://go.microsoft.com/fwlink/?linkid=2216041) by September 16, 2024 and they migrate (https://go.microsoft.com/fwlink/?linkid=2202255) to Azure Database for MySQL - Flexible Server and its sub resources now. Please use the `azurerm_mysql_flexible_server_active_directory_administrator` resource instead.", | |
| DeprecationMessage: "Azure Database for MySQL Single Server and its sub resources are scheduled for retirement by 2024-09-16 and will migrate to using Azure Database for MySQL Flexible Server: https://go.microsoft.com/fwlink/?linkid=2216041. The `azurerm_mysql_active_directory_administrator` resource is deprecated and will be removed in v4.0 of the AzureRM Provider. Please use the `azurerm_mysql_flexible_server_active_directory_administrator` resource instead.", |
| @@ -24,6 +24,8 @@ func resourceMySQLConfiguration() *pluginsdk.Resource { | |||
| Read: resourceMySQLConfigurationRead, | |||
| Delete: resourceMySQLConfigurationDelete, | |||
|
|
|||
| DeprecationMessage: "The `azurerm_mysql_configuration` resource will be deprecated since Azure Database for MySQL - Single Server and its sub resources are scheduled for retirement (https://go.microsoft.com/fwlink/?linkid=2216041) by September 16, 2024 and they migrate (https://go.microsoft.com/fwlink/?linkid=2202255) to Azure Database for MySQL - Flexible Server and its sub resources now. Please use the `azurerm_mysql_flexible_server_configuration` resource instead.", | |||
There was a problem hiding this comment.
Can you please apply the suggestion made above to all of the deprecation messages in this PR
There was a problem hiding this comment.
Updated to all.
|
@stephybun , thanks for the comments. I updated PR. Please take another look. Thanks. |
stephybun
approved these changes
Mar 15, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service team is reaching us to add this warning for deprecating Mysql Single Server and its sub resources.