Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - various 4.0 changes #25296

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Conversation

stephybun
Copy link
Member

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This PR contains the following changes for 4.0:

  • Removes the default values for image_cleaner_enabled and image_cleaner_interval_hours, closes Support image_cleaner block doesn't work as expected #19654
  • Renames automatic_channel_upgrade - > automatic_upgrade_channel (to better align with the API)
  • Renames node_os_channel_upgrade - > node_os_upgrade_channel (to better align with the API)
  • Lowers the upper limit for the idle_timeout_in_minutes validation function

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments but 👍

@stephybun stephybun merged commit cccc75b into main Mar 18, 2024
32 checks passed
@stephybun stephybun deleted the b/aks-image-cleaner branch March 18, 2024 14:17
@github-actions github-actions bot added this to the v3.97.0 milestone Mar 18, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support image_cleaner block doesn't work as expected
2 participants