azurerm_windows_web_app, azurerm_windows_function_app, azurerm_linux_function_app, azurerm_linux_web_app - support for minimum_tls_cipher_suite property

[xiaxyi]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_windows_web_app, azurerm_windows_function_app, azurerm_linux_function_app, azurerm_linux_web_app - support for theminimum_tls_cipher_suite property.

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #24223

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[jackofallops]

Thanks @xiaxyi - This looks good, but we'll end up with the related slot resources out of step, can you either add the same property there, or open a 2nd PR with those in so we can merge it all together?

Thanks

[xiaxyi]

Thanks @jackofallops for the review! Added the property to the slot in this pr. Let me know if anything needed.

[Tolbin400]

@xiaxyi @jackofallops what outstanding items are there before the pr can be approved for release?

[DempseySbaiz]

Any updates on this please, our client is asking for this feature.
The change request has been addressed in the PR.

[serakis]

Also interested to get this feature! Any news on the progress?

[rmcolbert]

Thanks @xiaxyi - This looks good, but we'll end up with the related slot resources out of step, can you either add the same property there, or open a 2nd PR with those in so we can merge it all together?

Thanks

@jackofallops, Code for slots was added in August. Is there anything else you wanted updated?

[jackofallops]

Hi @xiaxyi - Thanks for making those changes. I've left one comment below regarding what appears to be a copy-paste error if you can take a look. Also, some tests are now failing with errors of the following type:

        unexpected status 400 (400 Bad Request) with response:
        {"Code":"BadRequest","Message":"Tls13 does not support re-negotiation. Please
        either disable ClientCert, or set ClientCertMode to Application or Required
        (without exclsuion paths).","Target":null,"Details":[{"Message":"Tls13 does
        not support re-negotiation. Please either disable ClientCert, or set
        ClientCertMode to Application or Required (without exclsuion
        paths)

(The typo in the error message there is from the API)

I'll link you the regression test run from the CI server offline.

[github-actions]

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

[jackofallops]

Hi @xiaxyi - Thanks for the updates, looks like there's still a test that is failing due to a ForceNew change.

------- Stdout: -------
=== RUN   TestAccLinuxFunctionApp_tlsSettingUpdate
=== PAUSE TestAccLinuxFunctionApp_tlsSettingUpdate
=== CONT  TestAccLinuxFunctionApp_tlsSettingUpdate
    testcase.go:173: Step 4/12 error: Pre-apply plan check(s) failed:
        'azurerm_linux_function_app.test' - expected action to not be Replace, path: [[name]] tried to update a value that is ForceNew
--- FAIL: TestAccLinuxFunctionApp_tlsSettingUpdate (433.71s)