Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 4.0 Docs TODOs #28490

Merged
merged 12 commits into from
Jan 16, 2025
Merged

Implement 4.0 Docs TODOs #28490

merged 12 commits into from
Jan 16, 2025

Conversation

wyattfry
Copy link
Collaborator

@wyattfry wyattfry commented Jan 13, 2025

Advances hashicorp/tf-azure-stratosphere: 4.0 - Implement all 4.0 TODOs

First round of 4.0 documentation updates.

@github-actions github-actions bot added size/S and removed size/XS labels Jan 13, 2025
@github-actions github-actions bot added size/M and removed size/S labels Jan 13, 2025
@wyattfry wyattfry marked this pull request as ready for review January 14, 2025 15:29
@wyattfry wyattfry requested a review from a team as a code owner January 14, 2025 15:29
@github-actions github-actions bot added size/S and removed size/XL labels Jan 15, 2025
@wyattfry wyattfry changed the title Implement 4.0 TODOs Implement 4.0 Docs TODOs Jan 15, 2025
Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wyattfry - One comment to check if you could?

website/docs/r/key_vault.html.markdown Outdated Show resolved Hide resolved
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
Copy link
Collaborator

@sreallymatt sreallymatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wyattfry, LGTM

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry dismissed jackofallops’s stale review January 16, 2025 22:01

Wyatt addressed this review!

@wyattfry wyattfry merged commit ce9d7aa into main Jan 16, 2025
8 checks passed
@wyattfry wyattfry deleted the wyatt/todos-4-0 branch January 16, 2025 22:02
@github-actions github-actions bot added this to the v4.17.0 milestone Jan 16, 2025
NotTheEvilOne pushed a commit to b1-systems/terraform-provider-azurerm that referenced this pull request Jan 20, 2025
* Implement 4.0 TODOs

* wip

* wip

* 4.0 updates

* 4.0 updates

* 4.0 updates

* fixed broken tests

* new sso property

* checkout code changes from main, moving to new PR

* missed corresponding docs changes

* Update website/docs/r/windows_function_app_slot.html.markdown

Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>

* Update website/docs/r/key_vault.html.markdown

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

---------

Co-authored-by: sreallymatt <106555974+sreallymatt@users.noreply.github.com>
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants