Implement vault batch_input to decrypt multiple attributes efficiently #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds __vault_load_all_attributes which uses the vault decrypt batch_input API Adds a new vault_batch_decrypt setting to enable this behavior on an encrypted model Adds tests to exercise the new batching behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As currently implemented, __vault_load_attributes loops over __vault_load_attribute if vault_single_decrypt is disabled. In the case where an encrypted model has many vault attributes this will incur a vault load per attribute.
Vault supports batch_input/batch_results on the decrypt API which allows loading all of the decrypted data for multiple attributes in a single vault call.
This adds the decrypt_all call to Vault::Rails which internally uses batch_input.
Also added is support code to use this and some test code to verify correctness.