H-3134: Apply ESLint autofixes #4745

indietyp · 2024-07-19T21:30:33Z

🌟 What is the purpose of this PR?

This PR adds a new ESLint configuration, which is more encompassing and stricter than the previous one.

This is the second PR, building on top of #4232, and applies all auto fixes. The next PRs will focus on different subpackages to remove the remaining errors.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

affected the execution graph, and the turbo.json's have been updated to reflect this

semgrep-app · 2024-07-19T21:32:33Z

libs/@local/hash-isomorphic-utils/src/create-apollo-client.ts

      try {
        ({ operationName } = JSON.parse(options.body));
-      } catch (err) {
-        // eslint-disable-next-line no-console -- TODO: consider using logger
-        console.error(err);
+      } catch (error) {
+        console.error(error);
      }


Error messages with stack traces may expose sensitive information about the application.
_{Ignore this finding from generic_error_disclosure.}

Where removing comments, there will be cases when we want to ensure that manually added notes/todos (e.g. consideration for using a logger) are persisted.

semgrep-app · 2024-07-19T21:32:35Z

blocks/code/src/app.tsx

-      // eslint-disable-next-line no-console -- TODO: consider using logger
-      console.error(err);
+    } catch (error) {
+      console.error(error);
    }


Error messages with stack traces may expose sensitive information about the application.
_{Ignore this finding from generic_error_disclosure.}

semgrep-app · 2024-07-19T21:32:37Z

libs/@local/hash-isomorphic-utils/src/generate-entity-label.ts

@@ -71,7 +77,6 @@ export const generateEntityLabel = (

      entityType = entityTypeAndAncestors[0];
    } catch (error) {
-      // eslint-disable-next-line no-console -- prefer not to crash here but still have some feedback that there's an issue
      console.error(
        `Error looking for entity type and ancestors in provided subgraph: ${
          (error as Error).message


Error messages with stack traces may expose sensitive information about the application.
_{Ignore this finding from generic_error_disclosure.}

semgrep-app · 2024-07-20T14:44:30Z

apps/hash-frontend/src/components/sandbox/framed-block/framed-block.tsx


-    return () => window.removeEventListener("message", msgHandler);
+    window.addEventListener("message", messageHandler);


No validation of origin is done by the addEventListener API. It may be possible to exploit this flaw to perform Cross Origin attacks such as Cross-Site Scripting(XSS).
_{Ignore this finding from insufficient-postmessage-origin-validation.}

semgrep-app · 2024-07-20T14:44:34Z

apps/hash-frontend/src/pages/shared/block-collection/collab/http.ts

        }
      }
-      request.send(conf.body ?? null);
+      request.send(config.body ?? null);
    }),
    {
      abort() {


Depending on the context, user control data in Object.assign can cause web response to include data that it should not have or can lead to a mass assignment vulnerability.

View Dataflow Graph

flowchart LR classDef invis fill:white, stroke: none classDef default fill:#e7f5ff, color:#1c7fd6, stroke: none subgraph File0["apps/hash-frontend/src/pages/shared/block-collection/collab/http.ts"] direction LR %% Source subgraph Source direction LR v0["<a href=https://github.com/hashintel/hash/blob/56b6061ed2cd662197c1442071258c0501aa60bf/apps/hash-frontend/src/pages/shared/block-collection/collab/http.ts#L72 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 72] config.headers</a>"] end %% Intermediate %% Sink subgraph Sink direction LR v1["<a href=https://github.com/hashintel/hash/blob/56b6061ed2cd662197c1442071258c0501aa60bf/apps/hash-frontend/src/pages/shared/block-collection/collab/http.ts#L37 target=_blank style='text-decoration:none; color:#1c7fd6'>[Line: 37] Object.assign( new Promise<string>((resolve, reject) => { request.open(config.method, config.url, true); request.withCredentials = true; request.addEventListener("load", () => { if (aborted) { return; } if (request.status < 400) { finished = true; resolve(request.responseText); } else { let text = request.responseText; if ( text && (request.getResponseHeader("content-type") ?? "").includes("html") ) { text = makePlain(text); } const error = new StatusError( request.status, `Request failed: ${request.statusText}${text ? `\n\n${text}` : ""}`, ); finished = true; reject(error); } }); request.addEventListener("error", () => { if (!aborted) { finished = true; reject(new Error("Network error")); } }); if (config.headers) { for (const header of Object.keys(config.headers)) { request.setRequestHeader(header, config.headers[header]!); } } request.send(config.body ?? null); }), { abort() { if (!aborted && !finished) { request.abort(); onAbort?.(); aborted = true; } }, }, )</a>"] end end %% Class Assignment Source:::invis Sink:::invis File0:::invis %% Connections Source --> Sink

Loading

_{Ignore this finding from express-data-exfiltration.}

github-actions · 2024-07-20T15:13:38Z

Benchmark results

@rust/graph-benches – Integrations

representative_read_multiple_entities

Function	Value	Mean	Flame graphs
link_by_source_by_property	depths: DT=255, PT=255, ET=255, E=255	$$1.99 \mathrm{s} \pm 5.40 \mathrm{ms}\left({\color{gray}-0.038 \mathrm{\%}}\right) $$	Flame Graph
link_by_source_by_property	depths: DT=0, PT=2, ET=2, E=2	$$1.03 \mathrm{s} \pm 6.25 \mathrm{ms}\left({\color{gray}-0.658 \mathrm{\%}}\right) $$	Flame Graph
link_by_source_by_property	depths: DT=2, PT=2, ET=2, E=2	$$1.03 \mathrm{s} \pm 2.66 \mathrm{ms}\left({\color{gray}-0.944 \mathrm{\%}}\right) $$	Flame Graph
link_by_source_by_property	depths: DT=0, PT=0, ET=0, E=0	$$39.0 \mathrm{ms} \pm 269 \mathrm{μs}\left({\color{gray}-2.577 \mathrm{\%}}\right) $$	Flame Graph
link_by_source_by_property	depths: DT=0, PT=0, ET=2, E=2	$$405 \mathrm{ms} \pm 1.58 \mathrm{ms}\left({\color{gray}0.318 \mathrm{\%}}\right) $$	Flame Graph
link_by_source_by_property	depths: DT=0, PT=0, ET=0, E=2	$$75.0 \mathrm{ms} \pm 383 \mathrm{μs}\left({\color{gray}-3.830 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=255, PT=255, ET=255, E=255	$$2.89 \mathrm{s} \pm 10.1 \mathrm{ms}\left({\color{gray}-0.006 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=0, PT=2, ET=2, E=2	$$981 \mathrm{ms} \pm 3.11 \mathrm{ms}\left({\color{gray}-3.833 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=2, PT=2, ET=2, E=2	$$994 \mathrm{ms} \pm 3.97 \mathrm{ms}\left({\color{gray}-1.203 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=0, PT=0, ET=0, E=0	$$37.4 \mathrm{ms} \pm 274 \mathrm{μs}\left({\color{gray}-0.070 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=0, PT=0, ET=2, E=2	$$362 \mathrm{ms} \pm 1.61 \mathrm{ms}\left({\color{gray}-3.186 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=0, PT=0, ET=0, E=2	$$41.2 \mathrm{ms} \pm 226 \mathrm{μs}\left({\color{gray}-1.570 \mathrm{\%}}\right) $$	Flame Graph

scaling_read_entity_linkless

Function	Value	Mean	Flame graphs
entity_by_id	100 entities	$$2.03 \mathrm{ms} \pm 10.2 \mathrm{μs}\left({\color{gray}0.119 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	10 entities	$$1.84 \mathrm{ms} \pm 7.10 \mathrm{μs}\left({\color{gray}0.170 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	1 entities	$$1.84 \mathrm{ms} \pm 8.47 \mathrm{μs}\left({\color{gray}-0.029 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	1000 entities	$$2.76 \mathrm{ms} \pm 10.3 \mathrm{μs}\left({\color{gray}-2.383 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	10000 entities	$$13.3 \mathrm{ms} \pm 160 \mathrm{μs}\left({\color{gray}-0.387 \mathrm{\%}}\right) $$	Flame Graph

representative_read_entity_type

Function	Value	Mean	Flame graphs
get_entity_type_by_id	Account ID: `d4e16033-c281-4cde-aa35-9085bf2e7579`	$$1.41 \mathrm{ms} \pm 6.03 \mathrm{μs}\left({\color{gray}0.400 \mathrm{\%}}\right) $$	Flame Graph

scaling_read_entity_complete_one_depth

Function	Value	Mean	Flame graphs
entity_by_id	25 entities	$$76.0 \mathrm{ms} \pm 353 \mathrm{μs}\left({\color{gray}-1.039 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	5 entities	$$24.5 \mathrm{ms} \pm 222 \mathrm{μs}\left({\color{gray}1.55 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	50 entities	$$273 \mathrm{ms} \pm 1.53 \mathrm{ms}\left({\color{gray}0.048 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	10 entities	$$50.0 \mathrm{ms} \pm 1.19 \mathrm{ms}\left({\color{red}20.3 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	1 entities	$$19.8 \mathrm{ms} \pm 93.0 \mathrm{μs}\left({\color{gray}-0.936 \mathrm{\%}}\right) $$	Flame Graph

scaling_read_entity_complete_zero_depth

Function	Value	Mean	Flame graphs
entity_by_id	25 entities	$$3.13 \mathrm{ms} \pm 11.0 \mathrm{μs}\left({\color{red}22.5 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	5 entities	$$1.89 \mathrm{ms} \pm 11.1 \mathrm{μs}\left({\color{gray}-0.555 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	50 entities	$$4.20 \mathrm{ms} \pm 34.0 \mathrm{μs}\left({\color{red}6.90 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	10 entities	$$2.08 \mathrm{ms} \pm 19.3 \mathrm{μs}\left({\color{gray}1.16 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	1 entities	$$1.86 \mathrm{ms} \pm 7.58 \mathrm{μs}\left({\color{gray}-0.014 \mathrm{\%}}\right) $$	Flame Graph

representative_read_entity

Function	Value	Mean	Flame graphs
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/person/v/1`	$$16.8 \mathrm{ms} \pm 188 \mathrm{μs}\left({\color{lightgreen}-7.460 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1`	$$16.8 \mathrm{ms} \pm 197 \mathrm{μs}\left({\color{gray}3.72 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/book/v/1`	$$17.2 \mathrm{ms} \pm 239 \mathrm{μs}\left({\color{gray}1.48 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/building/v/1`	$$16.9 \mathrm{ms} \pm 228 \mathrm{μs}\left({\color{gray}-3.447 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/page/v/2`	$$16.8 \mathrm{ms} \pm 257 \mathrm{μs}\left({\color{lightgreen}-33.218 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/organization/v/1`	$$16.9 \mathrm{ms} \pm 235 \mathrm{μs}\left({\color{gray}0.498 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/song/v/1`	$$17.2 \mathrm{ms} \pm 228 \mathrm{μs}\left({\color{gray}3.93 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/playlist/v/1`	$$16.7 \mathrm{ms} \pm 242 \mathrm{μs}\left({\color{lightgreen}-6.717 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: `https://blockprotocol.org/@alice/types/entity-type/block/v/1`	$$17.1 \mathrm{ms} \pm 262 \mathrm{μs}\left({\color{gray}2.09 \mathrm{\%}}\right) $$	Flame Graph

vilkinsons · 2024-11-09T20:03:55Z

Closing following internal discussion.

indietyp added 8 commits July 19, 2024 19:40

chore: first run

d875402

chore: prettier

ce6eeb2

fix: syntax error

3cb9af6

chore: second run

5c5b787

chore: prettier

fea6cf5

chore: eslint fix third run

0e5fa9d

chore: prettier

aaa89d6

chore: fourth run + prettier

7ad014a

indietyp changed the title ~~eslint-fix~~ auto apply ES-Lint fixes Jul 19, 2024

indietyp changed the base branch from main to bm/repo/eslint July 19, 2024 21:32

semgrep-app bot reviewed Jul 19, 2024

View reviewed changes

vercel bot had a problem deploying to Preview – hashdotdesign July 19, 2024 21:41 Failure

vercel bot deployed to Preview – hashdotdev July 19, 2024 21:42 View deployment

vercel bot had a problem deploying to Preview – hash July 19, 2024 21:51 Failure

indietyp added 3 commits July 20, 2024 09:54

chore: autofix frontend

372e4f5

chore: prettier

4151bee

chore: autofix frontend (II)

d5cb736

chore: eslint fix

56b6061

github-actions bot added area/deps Relates to third-party dependencies (area) type/eng > frontend Owned by the @frontend team labels Jul 20, 2024

semgrep-app bot reviewed Jul 20, 2024

View reviewed changes

vercel bot deployed to Preview – hashdotdev July 20, 2024 14:51 View deployment

vercel bot had a problem deploying to Preview – hash July 20, 2024 14:51 Failure

vercel bot had a problem deploying to Preview – hashdotdesign July 20, 2024 15:00 Failure

vilkinsons changed the title ~~auto apply ES-Lint fixes~~ H-3134: Apply ESLint autofixes Jul 21, 2024

vilkinsons assigned vilkinsons and indietyp and unassigned vilkinsons Jul 21, 2024

vilkinsons closed this Nov 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

H-3134: Apply ESLint autofixes #4745

H-3134: Apply ESLint autofixes #4745

indietyp commented Jul 19, 2024 •

edited

Loading

semgrep-app bot Jul 19, 2024

vilkinsons Jul 22, 2024

semgrep-app bot Jul 19, 2024

semgrep-app bot Jul 19, 2024

semgrep-app bot Jul 20, 2024

semgrep-app bot Jul 20, 2024

github-actions bot commented Jul 20, 2024

@rust/graph-benches – Integrations

representative_read_multiple_entities

scaling_read_entity_linkless

representative_read_entity_type

scaling_read_entity_complete_one_depth

scaling_read_entity_complete_zero_depth

representative_read_entity

vilkinsons commented Nov 9, 2024


		return () => window.removeEventListener("message", msgHandler);
		window.addEventListener("message", messageHandler);

H-3134: Apply ESLint autofixes #4745

H-3134: Apply ESLint autofixes #4745

Conversation

indietyp commented Jul 19, 2024 • edited Loading

🌟 What is the purpose of this PR?

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

📜 Does this require a change to the docs?

🕸️ Does this require a change to the Turbo Graph?

semgrep-app bot Jul 19, 2024

Choose a reason for hiding this comment

vilkinsons Jul 22, 2024

Choose a reason for hiding this comment

semgrep-app bot Jul 19, 2024

Choose a reason for hiding this comment

semgrep-app bot Jul 19, 2024

Choose a reason for hiding this comment

semgrep-app bot Jul 20, 2024

Choose a reason for hiding this comment

semgrep-app bot Jul 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2024

Benchmark results

@rust/graph-benches – Integrations

representative_read_multiple_entities

scaling_read_entity_linkless

representative_read_entity_type

scaling_read_entity_complete_one_depth

scaling_read_entity_complete_zero_depth

representative_read_entity

vilkinsons commented Nov 9, 2024

indietyp commented Jul 19, 2024 •

edited

Loading