H-3337: Align type-system data-type constraints with Node API

[TimDiekmann]

🌟 What is the purpose of this PR?

The Node API exposes more constraints than the Graph. The graph needs to catch up and properly handle these constraints such as items and prefixItems. This is a preparation to allow anyOf for the Value data type, which does not have a type specified.

🔍 What does this change?

• Moves constraints out of DataType and make them dedicated schemas.
• Remove the integer type (we have multipleOf)
• Carefully design the Rust-side of the type system to keep deny_unknown_fields on DataType
• Expose more constraints for type = "array", including prefixItems and items: boolean
• Adjust the Node API for the changes

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

• does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

• are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

• do not affect the execution graph

[github-actions]

Benchmark results

@rust/graph-benches – Integrations

scaling_read_entity_linkless

Function	Value	Mean	Flame graphs
entity_by_id	10 entities	$$1.91 \mathrm{ms} \pm 6.47 \mathrm{μs}\left({\color{gray}1.04 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	100 entities	$$2.09 \mathrm{ms} \pm 8.09 \mathrm{μs}\left({\color{gray}2.95 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	1000 entities	$$2.82 \mathrm{ms} \pm 11.6 \mathrm{μs}\left({\color{gray}1.92 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	10000 entities	$$13.2 \mathrm{ms} \pm 133 \mathrm{μs}\left({\color{gray}4.54 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	1 entities	$$1.90 \mathrm{ms} \pm 6.57 \mathrm{μs}\left({\color{gray}1.90 \mathrm{\%}}\right) $$	Flame Graph

scaling_read_entity_complete_zero_depth

Function	Value	Mean	Flame graphs
entity_by_id	10 entities	$$2.13 \mathrm{ms} \pm 8.53 \mathrm{μs}\left({\color{gray}1.92 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	50 entities	$$3.99 \mathrm{ms} \pm 26.8 \mathrm{μs}\left({\color{gray}-2.080 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	5 entities	$$1.96 \mathrm{ms} \pm 16.5 \mathrm{μs}\left({\color{gray}2.06 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	25 entities	$$2.75 \mathrm{ms} \pm 56.1 \mathrm{μs}\left({\color{lightgreen}-5.857 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	1 entities	$$1.91 \mathrm{ms} \pm 13.0 \mathrm{μs}\left({\color{gray}-0.069 \mathrm{\%}}\right) $$	Flame Graph

representative_read_entity

Function	Value	Mean	Flame graphs
entity_by_id	entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1	$$17.2 \mathrm{ms} \pm 210 \mathrm{μs}\left({\color{gray}-1.747 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1	$$17.5 \mathrm{ms} \pm 213 \mathrm{μs}\left({\color{lightgreen}-30.689 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2	$$17.8 \mathrm{ms} \pm 235 \mathrm{μs}\left({\color{gray}1.48 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1	$$18.5 \mathrm{ms} \pm 233 \mathrm{μs}\left({\color{red}11.3 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1	$$17.3 \mathrm{ms} \pm 245 \mathrm{μs}\left({\color{gray}-3.532 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1	$$18.7 \mathrm{ms} \pm 203 \mathrm{μs}\left({\color{gray}3.69 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1	$$17.3 \mathrm{ms} \pm 214 \mathrm{μs}\left({\color{gray}3.29 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1	$$16.9 \mathrm{ms} \pm 237 \mathrm{μs}\left({\color{gray}0.603 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1	$$16.8 \mathrm{ms} \pm 181 \mathrm{μs}\left({\color{gray}-0.446 \mathrm{\%}}\right) $$	Flame Graph

representative_read_entity_type

Function	Value	Mean	Flame graphs
get_entity_type_by_id	Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579	$$1.45 \mathrm{ms} \pm 6.73 \mathrm{μs}\left({\color{gray}0.090 \mathrm{\%}}\right) $$	Flame Graph

scaling_read_entity_complete_one_depth

Function	Value	Mean	Flame graphs
entity_by_id	10 entities	$$31.4 \mathrm{ms} \pm 143 \mathrm{μs}\left({\color{lightgreen}-39.652 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	50 entities	$$276 \mathrm{ms} \pm 1.23 \mathrm{ms}\left({\color{gray}-1.464 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	5 entities	$$25.5 \mathrm{ms} \pm 258 \mathrm{μs}\left({\color{gray}1.01 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	25 entities	$$74.9 \mathrm{ms} \pm 568 \mathrm{μs}\left({\color{gray}0.699 \mathrm{\%}}\right) $$	Flame Graph
entity_by_id	1 entities	$$20.0 \mathrm{ms} \pm 105 \mathrm{μs}\left({\color{gray}-2.062 \mathrm{\%}}\right) $$	Flame Graph

representative_read_multiple_entities

Function	Value	Mean	Flame graphs
link_by_source_by_property	depths: DT=2, PT=2, ET=2, E=2	$$103 \mathrm{ms} \pm 556 \mathrm{μs}\left({\color{gray}-0.429 \mathrm{\%}}\right) $$	Flame Graph
link_by_source_by_property	depths: DT=0, PT=2, ET=2, E=2	$$98.1 \mathrm{ms} \pm 360 \mathrm{μs}\left({\color{gray}-2.046 \mathrm{\%}}\right) $$	Flame Graph
link_by_source_by_property	depths: DT=255, PT=255, ET=255, E=255	$$110 \mathrm{ms} \pm 498 \mathrm{μs}\left({\color{gray}-1.278 \mathrm{\%}}\right) $$	Flame Graph
link_by_source_by_property	depths: DT=0, PT=0, ET=0, E=0	$$44.3 \mathrm{ms} \pm 153 \mathrm{μs}\left({\color{gray}-0.737 \mathrm{\%}}\right) $$	Flame Graph
link_by_source_by_property	depths: DT=0, PT=0, ET=0, E=2	$$83.2 \mathrm{ms} \pm 436 \mathrm{μs}\left({\color{gray}-1.680 \mathrm{\%}}\right) $$	Flame Graph
link_by_source_by_property	depths: DT=0, PT=0, ET=2, E=2	$$94.6 \mathrm{ms} \pm 376 \mathrm{μs}\left({\color{gray}-0.872 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=2, PT=2, ET=2, E=2	$$61.6 \mathrm{ms} \pm 210 \mathrm{μs}\left({\color{gray}-0.400 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=0, PT=2, ET=2, E=2	$$57.3 \mathrm{ms} \pm 202 \mathrm{μs}\left({\color{gray}-0.051 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=255, PT=255, ET=255, E=255	$$69.7 \mathrm{ms} \pm 286 \mathrm{μs}\left({\color{gray}-0.901 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=0, PT=0, ET=0, E=0	$$41.3 \mathrm{ms} \pm 267 \mathrm{μs}\left({\color{gray}-2.075 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=0, PT=0, ET=0, E=2	$$46.3 \mathrm{ms} \pm 210 \mathrm{μs}\left({\color{gray}-0.827 \mathrm{\%}}\right) $$	Flame Graph
entity_by_property	depths: DT=0, PT=0, ET=2, E=2	$$52.8 \mathrm{ms} \pm 301 \mathrm{μs}\left({\color{gray}-1.067 \mathrm{\%}}\right) $$	Flame Graph

[CiaranMn]

Thanks @TimDiekmann! One non-blocking question

[CiaranMn]

Is there some follow-up to restore this? Or should it just be removed?

[TimDiekmann]

I'm going to re-add this. It's disabled here because Tsify creates a interface ClosedDataType extends DataType with DataType being a type, not an interface, and extending a type is not allowed. We don't expose ClosedDataType from the graph currently anyway, so currently it's unused. I decided to deal with this later.