Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust toolchains to nightly-2024-09-23 #5216

Merged
merged 7 commits into from
Sep 24, 2024
Merged

Conversation

hash-worker[bot]
Copy link
Contributor

@hash-worker hash-worker bot commented Sep 23, 2024

This PR contains the following updates:

Package Update Change
rust patch 2024-09-16 -> 2024-09-23

Configuration

📅 Schedule: Branch creation - "before 11am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@hash-worker hash-worker bot enabled auto-merge September 23, 2024 12:03
@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area) area/libs > deer Affects the `deer` crate (library) area/libs > antsi Affects the `antsi` crate (library) area/libs > sarif Affects the `sarif` crate (library) labels Sep 23, 2024
hashdotai
hashdotai previously approved these changes Sep 23, 2024
Copy link
Member

@indietyp indietyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is changing some lines that the ES PRs ready for merging already touch, as this is only styling, I'd like until these are merged.

Copy link
Member

@TimDiekmann TimDiekmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for #5200

@hash-worker hash-worker bot force-pushed the deps/rs/rust-toolchains branch from f957006 to 46057e3 Compare September 24, 2024 08:19
hashdotai
hashdotai previously approved these changes Sep 24, 2024
TimDiekmann
TimDiekmann previously approved these changes Sep 24, 2024
@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) type/eng > backend Owned by the @backend team area/tests New or updated tests area/tests > integration New or updated integration tests area/apps area/apps > hash-graph labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.32%. Comparing base (79538a2) to head (4e77b65).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5216      +/-   ##
==========================================
+ Coverage   19.74%   20.32%   +0.58%     
==========================================
  Files         510      510              
  Lines       17161    17288     +127     
  Branches     2546     2546              
==========================================
+ Hits         3388     3514     +126     
- Misses      13761    13762       +1     
  Partials       12       12              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.58% <ø> (ø)
apps.hash-api 1.18% <ø> (ø)
local.hash-backend-utils 9.38% <ø> (ø)
local.hash-isomorphic-utils 1.06% <ø> (ø)
local.hash-subgraph 25.22% <ø> (ø)
rust.deer 5.88% <ø> (ø)
rust.error-stack 73.19% <ø> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hash-worker
Copy link
Contributor Author

hash-worker bot commented Sep 24, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

TimDiekmann
TimDiekmann previously approved these changes Sep 24, 2024
Copy link
Contributor

Benchmark results

@rust/graph-benches – Integrations

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 10 entities $$1.84 \mathrm{ms} \pm 4.38 \mathrm{μs}\left({\color{gray}-1.858 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.03 \mathrm{ms} \pm 12.9 \mathrm{μs}\left({\color{gray}1.45 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$3.42 \mathrm{ms} \pm 19.2 \mathrm{μs}\left({\color{red}23.9 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$12.1 \mathrm{ms} \pm 123 \mathrm{μs}\left({\color{gray}-3.054 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.83 \mathrm{ms} \pm 4.82 \mathrm{μs}\left({\color{gray}-1.594 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$1.98 \mathrm{ms} \pm 10.6 \mathrm{μs}\left({\color{gray}-4.556 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$3.98 \mathrm{ms} \pm 22.4 \mathrm{μs}\left({\color{gray}-1.570 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.88 \mathrm{ms} \pm 8.30 \mathrm{μs}\left({\color{gray}-0.094 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$2.50 \mathrm{ms} \pm 9.75 \mathrm{μs}\left({\color{lightgreen}-17.460 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.85 \mathrm{ms} \pm 6.41 \mathrm{μs}\left({\color{gray}-0.653 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$15.5 \mathrm{ms} \pm 194 \mathrm{μs}\left({\color{lightgreen}-34.875 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.3 \mathrm{ms} \pm 155 \mathrm{μs}\left({\color{lightgreen}-35.103 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.0 \mathrm{ms} \pm 206 \mathrm{μs}\left({\color{red}8.12 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$16.0 \mathrm{ms} \pm 170 \mathrm{μs}\left({\color{gray}-0.963 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$15.6 \mathrm{ms} \pm 147 \mathrm{μs}\left({\color{gray}-1.095 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$14.9 \mathrm{ms} \pm 154 \mathrm{μs}\left({\color{lightgreen}-5.831 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$15.5 \mathrm{ms} \pm 159 \mathrm{μs}\left({\color{gray}-4.720 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.3 \mathrm{ms} \pm 160 \mathrm{μs}\left({\color{gray}4.59 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.2 \mathrm{ms} \pm 189 \mathrm{μs}\left({\color{gray}1.95 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.39 \mathrm{ms} \pm 4.37 \mathrm{μs}\left({\color{gray}-1.498 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$50.9 \mathrm{ms} \pm 193 \mathrm{μs}\left({\color{gray}-0.804 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$271 \mathrm{ms} \pm 1.21 \mathrm{ms}\left({\color{lightgreen}-31.547 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$24.7 \mathrm{ms} \pm 185 \mathrm{μs}\left({\color{gray}-0.132 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$71.4 \mathrm{ms} \pm 277 \mathrm{μs}\left({\color{gray}-0.772 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$19.9 \mathrm{ms} \pm 78.1 \mathrm{μs}\left({\color{gray}0.312 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$97.1 \mathrm{ms} \pm 290 \mathrm{μs}\left({\color{gray}-0.141 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$92.8 \mathrm{ms} \pm 435 \mathrm{μs}\left({\color{gray}0.244 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$105 \mathrm{ms} \pm 359 \mathrm{μs}\left({\color{gray}-0.744 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$40.7 \mathrm{ms} \pm 149 \mathrm{μs}\left({\color{gray}-1.028 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$78.3 \mathrm{ms} \pm 299 \mathrm{μs}\left({\color{gray}-0.237 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$88.3 \mathrm{ms} \pm 263 \mathrm{μs}\left({\color{gray}-0.266 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$58.1 \mathrm{ms} \pm 197 \mathrm{μs}\left({\color{gray}0.107 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$53.1 \mathrm{ms} \pm 167 \mathrm{μs}\left({\color{gray}-1.589 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$65.9 \mathrm{ms} \pm 188 \mathrm{μs}\left({\color{gray}-0.222 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$38.3 \mathrm{ms} \pm 256 \mathrm{μs}\left({\color{gray}-0.918 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$42.3 \mathrm{ms} \pm 225 \mathrm{μs}\left({\color{gray}-0.850 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$49.0 \mathrm{ms} \pm 202 \mathrm{μs}\left({\color{gray}-1.370 \mathrm{\%}}\right) $$ Flame Graph

@hash-worker hash-worker bot added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 429ef6d Sep 24, 2024
157 of 158 checks passed
@hash-worker hash-worker bot deleted the deps/rs/rust-toolchains branch September 24, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-graph area/apps area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs > antsi Affects the `antsi` crate (library) area/libs > deer Affects the `deer` crate (library) area/libs > error-stack Affects the `error-stack` crate (library) area/libs > sarif Affects the `sarif` crate (library) area/libs Relates to first-party libraries/crates/packages (area) area/tests > integration New or updated integration tests area/tests New or updated tests type/eng > backend Owned by the @backend team
Development

Successfully merging this pull request may close these issues.

3 participants