Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-201: Remove once-cell dev-dependency #5542

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

TimDiekmann
Copy link
Member

🌟 What is the purpose of this PR?

We removed the usage of once-cell before, but didn't remove the dev-dependency on it.

@TimDiekmann TimDiekmann requested a review from indietyp November 2, 2024 13:01
@TimDiekmann TimDiekmann self-assigned this Nov 2, 2024
@TimDiekmann TimDiekmann enabled auto-merge November 2, 2024 13:01
@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area) labels Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.14%. Comparing base (d23aaa6) to head (1db342f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5542      +/-   ##
==========================================
+ Coverage   20.01%   20.14%   +0.12%     
==========================================
  Files         509      509              
  Lines       17285    17323      +38     
  Branches     2538     2538              
==========================================
+ Hits         3460     3490      +30     
- Misses      13787    13795       +8     
  Partials       38       38              
Flag Coverage Δ
rust.deer 5.88% <ø> (ø)
rust.error-stack 73.03% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 2, 2024

Benchmark results

@rust/graph-benches – Integrations

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.38 \mathrm{ms} \pm 4.72 \mathrm{μs}\left({\color{gray}-0.191 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$2.10 \mathrm{ms} \pm 8.23 \mathrm{μs}\left({\color{gray}0.115 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$5.28 \mathrm{ms} \pm 26.1 \mathrm{μs}\left({\color{gray}0.280 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.86 \mathrm{ms} \pm 11.7 \mathrm{μs}\left({\color{gray}0.451 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.93 \mathrm{ms} \pm 9.52 \mathrm{μs}\left({\color{gray}0.186 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.30 \mathrm{ms} \pm 20.7 \mathrm{μs}\left({\color{red}20.1 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 10 entities $$1.90 \mathrm{ms} \pm 7.26 \mathrm{μs}\left({\color{gray}0.589 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$3.05 \mathrm{ms} \pm 15.6 \mathrm{μs}\left({\color{red}6.93 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.88 \mathrm{ms} \pm 7.12 \mathrm{μs}\left({\color{gray}0.635 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$13.5 \mathrm{ms} \pm 83.9 \mathrm{μs}\left({\color{gray}0.255 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.05 \mathrm{ms} \pm 12.2 \mathrm{μs}\left({\color{gray}2.13 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$69.2 \mathrm{ms} \pm 402 \mathrm{μs}\left({\color{gray}-0.353 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$54.6 \mathrm{ms} \pm 271 \mathrm{μs}\left({\color{gray}-0.460 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$40.7 \mathrm{ms} \pm 306 \mathrm{μs}\left({\color{gray}-0.360 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$49.9 \mathrm{ms} \pm 277 \mathrm{μs}\left({\color{gray}-0.426 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$44.3 \mathrm{ms} \pm 232 \mathrm{μs}\left({\color{gray}-0.807 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$59.2 \mathrm{ms} \pm 253 \mathrm{μs}\left({\color{gray}0.085 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$107 \mathrm{ms} \pm 692 \mathrm{μs}\left({\color{gray}-0.676 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$93.6 \mathrm{ms} \pm 446 \mathrm{μs}\left({\color{gray}-0.667 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$43.1 \mathrm{ms} \pm 352 \mathrm{μs}\left({\color{gray}0.032 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$89.1 \mathrm{ms} \pm 674 \mathrm{μs}\left({\color{gray}-1.466 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$81.0 \mathrm{ms} \pm 417 \mathrm{μs}\left({\color{gray}-0.458 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$97.9 \mathrm{ms} \pm 431 \mathrm{μs}\left({\color{gray}-0.937 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$51.5 \mathrm{ms} \pm 223 \mathrm{μs}\left({\color{gray}0.612 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$558 \mathrm{ms} \pm 3.34 \mathrm{ms}\left({\color{red}103 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$19.8 \mathrm{ms} \pm 87.6 \mathrm{μs}\left({\color{gray}-0.607 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$24.6 \mathrm{ms} \pm 140 \mathrm{μs}\left({\color{gray}-1.088 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$75.1 \mathrm{ms} \pm 425 \mathrm{μs}\left({\color{gray}0.897 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.3 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{gray}-2.516 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$17.2 \mathrm{ms} \pm 213 \mathrm{μs}\left({\color{gray}1.59 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$17.1 \mathrm{ms} \pm 200 \mathrm{μs}\left({\color{gray}2.35 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.6 \mathrm{ms} \pm 153 \mathrm{μs}\left({\color{gray}0.428 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.8 \mathrm{ms} \pm 172 \mathrm{μs}\left({\color{gray}-3.442 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.9 \mathrm{ms} \pm 204 \mathrm{μs}\left({\color{gray}1.01 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$17.3 \mathrm{ms} \pm 211 \mathrm{μs}\left({\color{gray}3.25 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$15.7 \mathrm{ms} \pm 174 \mathrm{μs}\left({\color{gray}-3.406 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.5 \mathrm{ms} \pm 159 \mathrm{μs}\left({\color{gray}-2.290 \mathrm{\%}}\right) $$ Flame Graph

Merged via the queue into main with commit db64ec7 Nov 2, 2024
164 checks passed
@TimDiekmann TimDiekmann deleted the t/gen-201-replace-once-cell-with-lazylock branch November 2, 2024 13:38
JesusFileto pushed a commit to JesusFileto/Chonky that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deps Relates to third-party dependencies (area) area/libs > error-stack Affects the `error-stack` crate (library) area/libs Relates to first-party libraries/crates/packages (area)
Development

Successfully merging this pull request may close these issues.

2 participants