Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate ariadne to v0.5.0 #5550

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Update Rust crate ariadne to v0.5.0 #5550

merged 6 commits into from
Nov 4, 2024

Conversation

hash-worker[bot]
Copy link
Contributor

@hash-worker hash-worker bot commented Nov 2, 2024

This PR contains the following updates:

Package Type Update Change
ariadne workspace.dependencies minor =0.4.1 -> =0.5.0

Release Notes

zesterer/ariadne (ariadne)

v0.5.0

Added
  • Support for multi-line notes
  • Support for RangeInclusive as spans
Changed
  • Made Report::build accept a proper span, avoiding much type annotation trouble
Fixed
  • Handling of empty lines
  • Config::new() is now const
  • Several subtle formatting bugs

Configuration

📅 Schedule: Branch creation - "before 4am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@hash-worker hash-worker bot enabled auto-merge November 2, 2024 16:50
@hash-worker hash-worker bot requested a review from a team November 2, 2024 16:50
@github-actions github-actions bot added the area/deps Relates to third-party dependencies (area) label Nov 2, 2024
hashdotai
hashdotai previously approved these changes Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.14%. Comparing base (f67bc88) to head (826fd2a).
Report is 70 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5550      +/-   ##
==========================================
- Coverage   20.15%   20.14%   -0.01%     
==========================================
  Files         509      509              
  Lines       17319    17323       +4     
  Branches     2538     2538              
==========================================
  Hits         3490     3490              
- Misses      13791    13795       +4     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team labels Nov 4, 2024
@indietyp
Copy link
Member

indietyp commented Nov 4, 2024

@TimDiekmann review would be appreciated, some changes needed to be done for this to work correctly.

span,
labels,

labels: labels?,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason why we don't try! above? Then this would become

Suggested change
labels: labels?,
labels,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, see: 22eb7f2

@hash-worker
Copy link
Contributor Author

hash-worker bot commented Nov 4, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

TimDiekmann
TimDiekmann previously approved these changes Nov 4, 2024
@TimDiekmann
Copy link
Member

Great, thank you!

@hash-worker hash-worker bot added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit fb84b51 Nov 4, 2024
163 checks passed
@hash-worker hash-worker bot deleted the deps/rs/ariadne-0.x branch November 4, 2024 13:00
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Benchmark results

@rust/graph-benches – Integrations

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.38 \mathrm{ms} \pm 5.29 \mathrm{μs}\left({\color{gray}0.438 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$2.11 \mathrm{ms} \pm 9.42 \mathrm{μs}\left({\color{gray}-0.385 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$5.26 \mathrm{ms} \pm 25.5 \mathrm{μs}\left({\color{red}24.3 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.85 \mathrm{ms} \pm 7.89 \mathrm{μs}\left({\color{gray}-0.124 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.89 \mathrm{ms} \pm 8.29 \mathrm{μs}\left({\color{gray}-0.415 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.31 \mathrm{ms} \pm 14.3 \mathrm{μs}\left({\color{gray}0.949 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 10 entities $$1.90 \mathrm{ms} \pm 11.0 \mathrm{μs}\left({\color{gray}0.711 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.81 \mathrm{ms} \pm 14.9 \mathrm{μs}\left({\color{gray}2.33 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.86 \mathrm{ms} \pm 6.45 \mathrm{μs}\left({\color{gray}1.66 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$13.4 \mathrm{ms} \pm 64.7 \mathrm{μs}\left({\color{gray}-1.580 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$1.96 \mathrm{ms} \pm 9.64 \mathrm{μs}\left({\color{gray}-3.599 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$69.6 \mathrm{ms} \pm 477 \mathrm{μs}\left({\color{gray}0.795 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$55.6 \mathrm{ms} \pm 374 \mathrm{μs}\left({\color{gray}2.50 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$41.6 \mathrm{ms} \pm 235 \mathrm{μs}\left({\color{gray}2.74 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$51.6 \mathrm{ms} \pm 256 \mathrm{μs}\left({\color{gray}2.67 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$45.4 \mathrm{ms} \pm 214 \mathrm{μs}\left({\color{gray}2.54 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$60.2 \mathrm{ms} \pm 326 \mathrm{μs}\left({\color{gray}2.55 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$108 \mathrm{ms} \pm 1.04 \mathrm{ms}\left({\color{gray}-0.353 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$93.6 \mathrm{ms} \pm 455 \mathrm{μs}\left({\color{gray}-0.401 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$42.8 \mathrm{ms} \pm 254 \mathrm{μs}\left({\color{gray}0.539 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$88.9 \mathrm{ms} \pm 398 \mathrm{μs}\left({\color{gray}-1.022 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$80.6 \mathrm{ms} \pm 416 \mathrm{μs}\left({\color{gray}-0.267 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$98.8 \mathrm{ms} \pm 719 \mathrm{μs}\left({\color{gray}0.104 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$47.5 \mathrm{ms} \pm 2.28 \mathrm{ms}\left({\color{gray}1.29 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$561 \mathrm{ms} \pm 3.77 \mathrm{ms}\left({\color{gray}0.685 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$19.9 \mathrm{ms} \pm 105 \mathrm{μs}\left({\color{gray}-0.354 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$24.9 \mathrm{ms} \pm 115 \mathrm{μs}\left({\color{gray}-0.581 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$74.9 \mathrm{ms} \pm 504 \mathrm{μs}\left({\color{gray}1.46 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$16.9 \mathrm{ms} \pm 200 \mathrm{μs}\left({\color{gray}1.46 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.8 \mathrm{ms} \pm 210 \mathrm{μs}\left({\color{gray}-0.618 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.4 \mathrm{ms} \pm 181 \mathrm{μs}\left({\color{gray}-0.593 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.6 \mathrm{ms} \pm 182 \mathrm{μs}\left({\color{gray}-2.442 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$17.1 \mathrm{ms} \pm 238 \mathrm{μs}\left({\color{gray}4.39 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$17.0 \mathrm{ms} \pm 209 \mathrm{μs}\left({\color{gray}-2.412 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$17.2 \mathrm{ms} \pm 218 \mathrm{μs}\left({\color{red}6.39 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.4 \mathrm{ms} \pm 193 \mathrm{μs}\left({\color{gray}-1.375 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$15.9 \mathrm{ms} \pm 202 \mathrm{μs}\left({\color{lightgreen}-5.150 \mathrm{\%}}\right) $$ Flame Graph

JesusFileto pushed a commit to JesusFileto/Chonky that referenced this pull request Nov 5, 2024
Co-authored-by: hash-worker[bot] <180894564+hash-worker[bot]@users.noreply.github.com>
Co-authored-by: Bilal Mahmoud <bmahmoud@mpi-cbg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deps Relates to third-party dependencies (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team
Development

Successfully merging this pull request may close these issues.

3 participants