-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H-3542: Make use of entity/type icons consistently #5598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. show link icon for link types without icon
…ity with a new type
github-actions
bot
added
area/apps > hash*
Affects HASH (a `hash-*` app)
area/libs
Relates to first-party libraries/crates/packages (area)
type/eng > frontend
Owned by the @frontend team
type/eng > backend
Owned by the @backend team
area/apps
labels
Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5598 +/- ##
==========================================
- Coverage 20.08% 20.08% -0.01%
==========================================
Files 514 514
Lines 17373 17375 +2
Branches 2546 2546
==========================================
Hits 3490 3490
- Misses 13845 13847 +2
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vilkinsons
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/apps > hash*
Affects HASH (a `hash-*` app)
area/apps
area/libs
Relates to first-party libraries/crates/packages (area)
type/eng > backend
Owned by the @backend team
type/eng > frontend
Owned by the @frontend team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
We allow users to set an
icon
for entity types – currently, via an emoji picker. But these icons weren't being displayed consistently in the app (in most places, the default asterisk icon was used).This PR improves that by:
It also adds supports for the
icon
property being a URL to an SVG.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
Inherited icons are not checked in most cases. This will be fixed in H-3363 by making use of the new 'closed' entity type schemas which resolve references to ancestors and work out what the nearest icon is.
Icons aren't used in the 'linked with' cell in the entity editor (non-readonly mode). H-3562.
📹 Demo