Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3558: harpc: rename Metadata to SubsystemInformation and ProcedureInformation #5599

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

indietyp
Copy link
Member

@indietyp indietyp commented Nov 7, 2024

🌟 What is the purpose of this PR?

Splits Metadata into SubsystemInformation and ProcedureInformation, additionally they are altered slightly as well as how they're constructed, to make overwriting them in the future easier and more consistent.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@indietyp indietyp requested a review from TimDiekmann November 7, 2024 13:28
@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team area/apps area/apps > hash-graph labels Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.08%. Comparing base (8042684) to head (0ebb795).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5599      +/-   ##
==========================================
- Coverage   20.08%   20.08%   -0.01%     
==========================================
  Files         514      514              
  Lines       17373    17375       +2     
  Branches     2546     2546              
==========================================
  Hits         3490     3490              
- Misses      13845    13847       +2     
  Partials       38       38              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.38% <ø> (ø)
apps.hash-api 1.17% <ø> (ø)
local.hash-backend-utils 8.80% <ø> (ø)
local.hash-isomorphic-utils 1.05% <ø> (-0.01%) ⬇️
local.hash-subgraph 24.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@indietyp indietyp enabled auto-merge November 7, 2024 13:33
@indietyp indietyp added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 84bb519 Nov 7, 2024
86 checks passed
@indietyp indietyp deleted the bm/harpc/metadata-rename branch November 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-graph area/apps area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team
Development

Successfully merging this pull request may close these issues.

2 participants