Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3564: Use consistent library structure for Rust crates #5600

Merged

Conversation

TimDiekmann
Copy link
Member

@TimDiekmann TimDiekmann commented Nov 7, 2024

🌟 What is the purpose of this PR?

Currently it's a wild mixture of apps/*/lib and libs/@local and the crate names varies between no prefix, graph- prefix and hash-graph prefix. As we're going to use the hash namespace, all crates should use hash- as prefix in the meantime. This has the advantage of them being grouped together in imports, it's easier to see where the packages are coming from, and what part of the project they belong to.

🔍 What does this change?

  • Remove query-builder-derive (unused and not expected to be used due to HQL)
  • Prefix HASH-related crates with hash-
  • Prefix Graph-related crates with graph- (in addition to hash-, so the prefix becomes hash-graph-)
  • Move graph-libraries out of apps/ (into libs/@local/graph)
  • Move graph-binary to apps/hash-graph

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/apps > hash* Affects HASH (a `hash-*` app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team area/tests New or updated tests area/apps area/apps > hash-graph type/legal Owned by the @legal team labels Nov 7, 2024
Copy link
Member Author

@TimDiekmann TimDiekmann Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This crate will be split into other crates as part of H-1000

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.84%. Comparing base (427c6e2) to head (70415d4).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5600      +/-   ##
==========================================
+ Coverage   19.68%   19.84%   +0.15%     
==========================================
  Files         514      515       +1     
  Lines       17288    17322      +34     
  Branches     2546     2546              
==========================================
+ Hits         3403     3437      +34     
  Misses      13847    13847              
  Partials       38       38              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.38% <ø> (ø)
apps.hash-api 1.17% <ø> (ø)
local.hash-backend-utils 8.80% <ø> (ø)
local.hash-graph-sdk 100.00% <ø> (?)
local.hash-isomorphic-utils 1.05% <ø> (ø)
local.hash-subgraph 24.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimDiekmann TimDiekmann force-pushed the t/h-3564-use-consistent-library-structure-for-rust-crates branch from c421a9c to 422470b Compare November 7, 2024 17:38
@TimDiekmann TimDiekmann added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit bc8b1dd Nov 8, 2024
160 of 162 checks passed
@TimDiekmann TimDiekmann deleted the t/h-3564-use-consistent-library-structure-for-rust-crates branch November 8, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-graph area/apps area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests > integration New or updated integration tests area/tests New or updated tests type/eng > backend Owned by the @backend team type/legal Owned by the @legal team
Development

Successfully merging this pull request may close these issues.

4 participants