-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H-3564: Use consistent library structure for Rust crates #5600
H-3564: Use consistent library structure for Rust crates #5600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This crate will be split into other crates as part of H-1000
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5600 +/- ##
==========================================
+ Coverage 19.68% 19.84% +0.15%
==========================================
Files 514 515 +1
Lines 17288 17322 +34
Branches 2546 2546
==========================================
+ Hits 3403 3437 +34
Misses 13847 13847
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c421a9c
to
422470b
Compare
🌟 What is the purpose of this PR?
Currently it's a wild mixture of
apps/*/lib
andlibs/@local
and the crate names varies between no prefix,graph-
prefix andhash-graph
prefix. As we're going to use thehash
namespace, all crates should use hash- as prefix in the meantime. This has the advantage of them being grouped together in imports, it's easier to see where the packages are coming from, and what part of the project they belong to.🔍 What does this change?
query-builder-derive
(unused and not expected to be used due to HQL)hash-
graph-
(in addition tohash-
, so the prefix becomeshash-graph-
)apps/
(intolibs/@local/graph
)apps/hash-graph
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR: