Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3740: Add uv.lock to ignore files #5804

Closed
wants to merge 4 commits into from
Closed

H-3740: Add uv.lock to ignore files #5804

wants to merge 4 commits into from

Conversation

vilkinsons
Copy link
Member

@vilkinsons vilkinsons commented Dec 4, 2024

🌟 What is the purpose of this PR?

Although deprecation is not immediate, uv will ultimately replace rye and we will want to migrate over. This PR pre-emptively adds uv.lock to our ignore files.

🔗 Related links

  • Rye and uv GitHub discussion thread in the rye repository

Follow-ups

  • Migrate from rye to uv

@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/apps > hash* Affects HASH (a `hash-*` app) area/infra Relates to version control, CI, CD or IaC (area) area/apps > hash-api Affects the HASH API (app) area/apps > hash.dev Affects the `hash.dev` developer site (app) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/apps labels Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Benchmark results

@rust/hash-graph-benches – Integrations

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.1 \mathrm{ms} \pm 190 \mathrm{μs}\left({\color{lightgreen}-31.180 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.6 \mathrm{ms} \pm 220 \mathrm{μs}\left({\color{gray}-2.982 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$17.2 \mathrm{ms} \pm 175 \mathrm{μs}\left({\color{red}5.18 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$17.6 \mathrm{ms} \pm 224 \mathrm{μs}\left({\color{gray}-0.460 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.3 \mathrm{ms} \pm 184 \mathrm{μs}\left({\color{gray}-4.859 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.7 \mathrm{ms} \pm 200 \mathrm{μs}\left({\color{lightgreen}-6.244 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.7 \mathrm{ms} \pm 172 \mathrm{μs}\left({\color{gray}-1.454 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$17.0 \mathrm{ms} \pm 221 \mathrm{μs}\left({\color{gray}0.206 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$16.8 \mathrm{ms} \pm 219 \mathrm{μs}\left({\color{gray}3.79 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$66.4 \mathrm{ms} \pm 337 \mathrm{μs}\left({\color{gray}0.673 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$39.3 \mathrm{ms} \pm 252 \mathrm{μs}\left({\color{gray}-4.086 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$57.7 \mathrm{ms} \pm 370 \mathrm{μs}\left({\color{gray}1.93 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$43.4 \mathrm{ms} \pm 215 \mathrm{μs}\left({\color{gray}-3.469 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$49.8 \mathrm{ms} \pm 322 \mathrm{μs}\left({\color{gray}0.038 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$54.1 \mathrm{ms} \pm 257 \mathrm{μs}\left({\color{gray}-1.154 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$110 \mathrm{ms} \pm 512 \mathrm{μs}\left({\color{gray}2.97 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$43.6 \mathrm{ms} \pm 160 \mathrm{μs}\left({\color{gray}2.20 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$102 \mathrm{ms} \pm 729 \mathrm{μs}\left({\color{gray}3.95 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$82.9 \mathrm{ms} \pm 556 \mathrm{μs}\left({\color{gray}-0.128 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$92.6 \mathrm{ms} \pm 611 \mathrm{μs}\left({\color{gray}-0.457 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$98.7 \mathrm{ms} \pm 482 \mathrm{μs}\left({\color{gray}4.08 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.38 \mathrm{ms} \pm 5.86 \mathrm{μs}\left({\color{gray}0.142 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$5.27 \mathrm{s} \pm 840 \mathrm{ms}\left({\color{gray}-3.375 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$26.4 \mathrm{ms} \pm 159 \mathrm{μs}\left({\color{gray}0.406 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$20.1 \mathrm{ms} \pm 117 \mathrm{μs}\left({\color{gray}-2.992 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$57.4 \mathrm{ms} \pm 310 \mathrm{μs}\left({\color{red}18.3 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$176 \mathrm{ms} \pm 607 \mathrm{μs}\left({\color{gray}-1.204 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$1.92 \mathrm{ms} \pm 5.96 \mathrm{μs}\left({\color{gray}-0.455 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.11 \mathrm{ms} \pm 5.46 \mathrm{μs}\left({\color{gray}0.172 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$1.95 \mathrm{ms} \pm 6.17 \mathrm{μs}\left({\color{gray}1.49 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.88 \mathrm{ms} \pm 12.0 \mathrm{μs}\left({\color{lightgreen}-7.750 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$14.0 \mathrm{ms} \pm 64.7 \mathrm{μs}\left({\color{gray}0.296 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$3.99 \mathrm{ms} \pm 15.0 \mathrm{μs}\left({\color{lightgreen}-20.582 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.97 \mathrm{ms} \pm 14.4 \mathrm{μs}\left({\color{gray}1.40 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.92 \mathrm{ms} \pm 6.05 \mathrm{μs}\left({\color{gray}-0.121 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.16 \mathrm{ms} \pm 14.8 \mathrm{μs}\left({\color{gray}0.035 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$2.77 \mathrm{ms} \pm 16.0 \mathrm{μs}\left({\color{lightgreen}-15.297 \mathrm{\%}}\right) $$ Flame Graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash.dev Affects the `hash.dev` developer site (app) area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team
Development

Successfully merging this pull request may close these issues.

1 participant