Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3745: Upgrade recursive dependencies and TemporalIO dependency #5837

Merged

Conversation

TimDiekmann
Copy link
Member

@TimDiekmann TimDiekmann commented Dec 8, 2024

🌟 What is the purpose of this PR?

We did not upgrade the Temporal dependency in a while. This also required some recursive dependencies to be upgraded (most importantly chromo) which is a feature which is sadly missing from Renovate.

🔍 What does this change?

  • Upgrade to latest Temporal version
  • Adjust and test new Temporal client code (minimal changes required)
  • Avoid the renaming of the temporal packages
  • Run cargo upgrade

@TimDiekmann TimDiekmann self-assigned this Dec 8, 2024
@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team labels Dec 8, 2024
Copy link
Contributor

github-actions bot commented Dec 8, 2024

Benchmark results

@rust/hash-graph-benches – Integrations

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.6 \mathrm{ms} \pm 134 \mathrm{μs}\left({\color{lightgreen}-27.272 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$15.7 \mathrm{ms} \pm 163 \mathrm{μs}\left({\color{gray}-4.304 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$15.4 \mathrm{ms} \pm 165 \mathrm{μs}\left({\color{gray}-4.862 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.6 \mathrm{ms} \pm 177 \mathrm{μs}\left({\color{gray}1.000 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.1 \mathrm{ms} \pm 179 \mathrm{μs}\left({\color{gray}-1.839 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.4 \mathrm{ms} \pm 183 \mathrm{μs}\left({\color{gray}0.950 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.8 \mathrm{ms} \pm 184 \mathrm{μs}\left({\color{red}7.03 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.5 \mathrm{ms} \pm 197 \mathrm{μs}\left({\color{lightgreen}-27.394 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.3 \mathrm{ms} \pm 180 \mathrm{μs}\left({\color{lightgreen}-14.022 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$64.4 \mathrm{ms} \pm 321 \mathrm{μs}\left({\color{gray}-1.169 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$37.2 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{gray}-0.857 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$55.8 \mathrm{ms} \pm 262 \mathrm{μs}\left({\color{gray}0.729 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$42.1 \mathrm{ms} \pm 454 \mathrm{μs}\left({\color{gray}0.486 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$46.7 \mathrm{ms} \pm 188 \mathrm{μs}\left({\color{gray}-2.198 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$51.5 \mathrm{ms} \pm 321 \mathrm{μs}\left({\color{gray}-0.884 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$105 \mathrm{ms} \pm 550 \mathrm{μs}\left({\color{gray}-1.035 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$41.3 \mathrm{ms} \pm 356 \mathrm{μs}\left({\color{gray}-0.639 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$96.7 \mathrm{ms} \pm 351 \mathrm{μs}\left({\color{gray}-0.845 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$79.6 \mathrm{ms} \pm 300 \mathrm{μs}\left({\color{gray}-0.827 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$88.6 \mathrm{ms} \pm 397 \mathrm{μs}\left({\color{gray}-1.768 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$94.4 \mathrm{ms} \pm 611 \mathrm{μs}\left({\color{gray}0.310 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.38 \mathrm{ms} \pm 5.02 \mathrm{μs}\left({\color{gray}-0.093 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$263 \mathrm{ms} \pm 1.27 \mathrm{ms}\left({\color{gray}0.539 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$26.1 \mathrm{ms} \pm 128 \mathrm{μs}\left({\color{gray}-0.076 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$19.8 \mathrm{ms} \pm 83.6 \mathrm{μs}\left({\color{gray}-2.769 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$56.1 \mathrm{ms} \pm 207 \mathrm{μs}\left({\color{red}15.2 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$175 \mathrm{ms} \pm 1.07 \mathrm{ms}\left({\color{gray}0.198 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$1.90 \mathrm{ms} \pm 5.63 \mathrm{μs}\left({\color{gray}-0.567 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.08 \mathrm{ms} \pm 8.57 \mathrm{μs}\left({\color{gray}2.28 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$1.92 \mathrm{ms} \pm 8.06 \mathrm{μs}\left({\color{gray}-0.318 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.95 \mathrm{ms} \pm 17.1 \mathrm{μs}\left({\color{gray}3.50 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$13.4 \mathrm{ms} \pm 52.5 \mathrm{μs}\left({\color{gray}-0.652 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$3.94 \mathrm{ms} \pm 15.4 \mathrm{μs}\left({\color{gray}-2.553 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.93 \mathrm{ms} \pm 8.42 \mathrm{μs}\left({\color{gray}-0.511 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.91 \mathrm{ms} \pm 6.51 \mathrm{μs}\left({\color{gray}-0.979 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.12 \mathrm{ms} \pm 11.2 \mathrm{μs}\left({\color{gray}-0.906 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.29 \mathrm{ms} \pm 16.3 \mathrm{μs}\left({\color{gray}-0.279 \mathrm{\%}}\right) $$ Flame Graph

@TimDiekmann TimDiekmann added this pull request to the merge queue Dec 8, 2024
Merged via the queue into main with commit a7f3936 Dec 8, 2024
165 of 166 checks passed
@TimDiekmann TimDiekmann deleted the t/h-3745-upgrade-temporal-to-a-more-recent-version branch December 8, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deps Relates to third-party dependencies (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team
Development

Successfully merging this pull request may close these issues.

2 participants