-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H-3609: Reduce cost of polling for notification and draft entities counts #5838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/apps > hash*
Affects HASH (a `hash-*` app)
area/libs
Relates to first-party libraries/crates/packages (area)
type/eng > frontend
Owned by the @frontend team
type/eng > backend
Owned by the @backend team
area/apps
labels
Dec 9, 2024
CiaranMn
changed the title
H-3609: Reduce cost of polling for notification and draft entities
H-3609: Reduce cost of polling for notification and draft entities counts
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5838 +/- ##
==========================================
- Coverage 22.99% 22.99% -0.01%
==========================================
Files 569 569
Lines 19096 19094 -2
Branches 2709 2709
==========================================
- Hits 4392 4390 -2
Misses 14652 14652
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vilkinsons
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/apps > hash*
Affects HASH (a `hash-*` app)
area/apps
area/libs
Relates to first-party libraries/crates/packages (area)
type/eng > backend
Owned by the @backend team
type/eng > frontend
Owned by the @frontend team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
We display a count of (a) notifications and (b) draft entities requiring processing in the top navigation bar and sidebar.
The data for this is currently fetched by an app-wide context which polls for notifications and draft entities. This fetches all the notification and draft entities, because it is also used by the notifications and draft queue pages, which require the actual entity data.
App-wide we only need the count of entities, not the entities themselves. This PR therefore splits those contexts out into (1) app-wide contexts for fetching the count only, and (2) contexts used in the relevant pages only, which gets the rest of the data.
This reduces the amount of data we are polling for while not on the notifications or draft queue pages.
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
❓ How to test this?