Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3817: Fix typo in GitHub Action name #5911

Merged
merged 6 commits into from
Dec 16, 2024
Merged

H-3817: Fix typo in GitHub Action name #5911

merged 6 commits into from
Dec 16, 2024

Conversation

vilkinsons
Copy link
Member

🌟 What is the purpose of this PR?

One of our SQLFluff GitHub actions has a typo in its name.

In general, the naming of the SQLFluff GitHub actions is also somewhat unclear. Comments/questions inline on this PR.

@vilkinsons vilkinsons self-assigned this Dec 14, 2024
@github-actions github-actions bot added the area/infra Relates to version control, CI, CD or IaC (area) label Dec 14, 2024
@@ -342,7 +342,7 @@ jobs:
- name: SQLFluff
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be more descriptive about what this step is, similar to the ones around it?

@@ -342,7 +342,7 @@ jobs:
- name: SQLFluff
run: sqlfluff lint --warn-unused-ignores

- name: Crate SQLFluff annotationss
- name: Create SQLFluff annotations
if: failure() && github.event.pull_request.head.repo.full_name == github.repository
run: sqlfluff lint --warn-unused-ignores --format github-annotation --write-output annotations.json --annotation-level failure --nofail

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the following step do on line 349? Attach the created annotations? It could also do with a more descriptive name.

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.72%. Comparing base (a0e38fe) to head (b843a95).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5911      +/-   ##
==========================================
- Coverage   22.90%   21.72%   -1.19%     
==========================================
  Files         572      566       -6     
  Lines       19394    19155     -239     
  Branches     2746     2752       +6     
==========================================
- Hits         4442     4161     -281     
- Misses      14899    14942      +43     
+ Partials       53       52       -1     
Flag Coverage Δ
apps.hash-ai-worker-ts 1.32% <ø> (-0.01%) ⬇️
apps.hash-api 1.16% <ø> (ø)
blockprotocol.type-system 46.42% <ø> (ø)
local.harpc-client 50.17% <ø> (-9.52%) ⬇️
local.hash-backend-utils 8.81% <ø> (ø)
local.hash-graph-sdk 58.62% <ø> (ø)
local.hash-isomorphic-utils 0.98% <ø> (ø)
local.hash-subgraph 24.54% <ø> (ø)
rust.deer 6.66% <ø> (ø)
rust.error-stack 72.51% <ø> (ø)
rust.sarif 88.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Tim Diekmann <21277928+TimDiekmann@users.noreply.github.com>
@TimDiekmann TimDiekmann self-requested a review December 15, 2024 14:58
TimDiekmann
TimDiekmann previously approved these changes Dec 15, 2024
hashdotai
hashdotai previously approved these changes Dec 16, 2024
Copy link
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.6 \mathrm{ms} \pm 152 \mathrm{μs}\left({\color{lightgreen}-27.455 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$15.9 \mathrm{ms} \pm 185 \mathrm{μs}\left({\color{gray}1.46 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.3 \mathrm{ms} \pm 163 \mathrm{μs}\left({\color{lightgreen}-5.354 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.0 \mathrm{ms} \pm 163 \mathrm{μs}\left({\color{lightgreen}-6.241 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.6 \mathrm{ms} \pm 174 \mathrm{μs}\left({\color{gray}-0.103 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.3 \mathrm{ms} \pm 189 \mathrm{μs}\left({\color{gray}0.309 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$15.7 \mathrm{ms} \pm 173 \mathrm{μs}\left({\color{gray}-0.978 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.2 \mathrm{ms} \pm 194 \mathrm{μs}\left({\color{lightgreen}-30.722 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$15.9 \mathrm{ms} \pm 162 \mathrm{μs}\left({\color{lightgreen}-8.472 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$69.2 \mathrm{ms} \pm 344 \mathrm{μs}\left({\color{gray}1.36 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$41.2 \mathrm{ms} \pm 246 \mathrm{μs}\left({\color{gray}2.65 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$58.7 \mathrm{ms} \pm 300 \mathrm{μs}\left({\color{gray}-0.654 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$44.9 \mathrm{ms} \pm 274 \mathrm{μs}\left({\color{gray}-2.103 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$50.5 \mathrm{ms} \pm 306 \mathrm{μs}\left({\color{gray}1.91 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$55.7 \mathrm{ms} \pm 306 \mathrm{μs}\left({\color{gray}2.37 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$103 \mathrm{ms} \pm 434 \mathrm{μs}\left({\color{gray}-0.935 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$40.3 \mathrm{ms} \pm 201 \mathrm{μs}\left({\color{gray}0.601 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$95.9 \mathrm{ms} \pm 394 \mathrm{μs}\left({\color{gray}1.29 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$78.5 \mathrm{ms} \pm 441 \mathrm{μs}\left({\color{gray}0.366 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$86.8 \mathrm{ms} \pm 354 \mathrm{μs}\left({\color{gray}-1.358 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$91.2 \mathrm{ms} \pm 409 \mathrm{μs}\left({\color{gray}-0.955 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$2.14 \mathrm{ms} \pm 6.63 \mathrm{μs}\left({\color{gray}-0.720 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$5.60 \mathrm{s} \pm 285 \mathrm{ms}\left({\color{red}1946 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$26.8 \mathrm{ms} \pm 194 \mathrm{μs}\left({\color{gray}-0.759 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$20.5 \mathrm{ms} \pm 107 \mathrm{μs}\left({\color{gray}-1.465 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$57.1 \mathrm{ms} \pm 186 \mathrm{μs}\left({\color{gray}-2.257 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$83.8 \mathrm{ms} \pm 474 \mathrm{μs}\left({\color{lightgreen}-52.536 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$1.94 \mathrm{ms} \pm 12.1 \mathrm{μs}\left({\color{gray}0.095 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.13 \mathrm{ms} \pm 8.62 \mathrm{μs}\left({\color{gray}0.580 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$1.95 \mathrm{ms} \pm 5.52 \mathrm{μs}\left({\color{gray}-0.227 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.98 \mathrm{ms} \pm 18.4 \mathrm{μs}\left({\color{gray}2.90 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$13.4 \mathrm{ms} \pm 36.6 \mathrm{μs}\left({\color{red}33.8 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$4.99 \mathrm{ms} \pm 24.5 \mathrm{μs}\left({\color{red}19.4 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.94 \mathrm{ms} \pm 6.37 \mathrm{μs}\left({\color{gray}-1.203 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.95 \mathrm{ms} \pm 13.6 \mathrm{μs}\left({\color{gray}0.028 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.11 \mathrm{ms} \pm 12.6 \mathrm{μs}\left({\color{gray}-0.973 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$2.72 \mathrm{ms} \pm 15.3 \mathrm{μs}\left({\color{lightgreen}-17.611 \mathrm{\%}}\right) $$ Flame Graph

Merged via the queue into main with commit 93c40b2 Dec 16, 2024
164 checks passed
@vilkinsons vilkinsons deleted the d/typo branch December 16, 2024 14:50
CiaranMn added a commit that referenced this pull request Jan 13, 2025
Co-authored-by: Tim Diekmann <21277928+TimDiekmann@users.noreply.github.com>
Co-authored-by: Ciaran Morinan <c@hash.ai>
Co-authored-by: Ciaran Morinan <37743469+CiaranMn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Relates to version control, CI, CD or IaC (area)
Development

Successfully merging this pull request may close these issues.

4 participants