Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3832: Upgrade to React 19, Next 15 #5945

Merged
merged 23 commits into from
Dec 20, 2024
Merged

H-3832: Upgrade to React 19, Next 15 #5945

merged 23 commits into from
Dec 20, 2024

Conversation

CiaranMn
Copy link
Member

@CiaranMn CiaranMn commented Dec 17, 2024

🌟 What is the purpose of this PR?

It upgrades to React 19 and Next 15.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/apps > hash* Affects HASH (a `hash-*` app) area/blocks Relates to first-party blocks (area) area/apps > hash.dev Affects the `hash.dev` developer site (app) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/apps area/apps > hash.design Affects the `hash.design` design site (app) labels Dec 17, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 21.72%. Comparing base (faf8281) to head (16cf15d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../@local/hash-isomorphic-utils/src/generate-uuid.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5945   +/-   ##
=======================================
  Coverage   21.72%   21.72%           
=======================================
  Files         566      566           
  Lines       19157    19156    -1     
  Branches     2755     2755           
=======================================
  Hits         4162     4162           
+ Misses      14943    14942    -1     
  Partials       52       52           
Flag Coverage Δ
apps.hash-ai-worker-ts 1.32% <ø> (ø)
apps.hash-api 1.16% <ø> (ø)
blockprotocol.type-system 46.42% <ø> (ø)
local.harpc-client 50.17% <ø> (ø)
local.hash-backend-utils 8.81% <ø> (ø)
local.hash-graph-sdk 58.62% <ø> (ø)
local.hash-isomorphic-utils 0.98% <0.00%> (+<0.01%) ⬆️
local.hash-subgraph 24.54% <ø> (ø)
rust.deer 6.66% <ø> (ø)
rust.error-stack 72.51% <ø> (ø)
rust.sarif 88.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$17.3 \mathrm{ms} \pm 204 \mathrm{μs}\left({\color{lightgreen}-23.389 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$16.1 \mathrm{ms} \pm 141 \mathrm{μs}\left({\color{gray}-4.142 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.6 \mathrm{ms} \pm 208 \mathrm{μs}\left({\color{red}5.70 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.2 \mathrm{ms} \pm 188 \mathrm{μs}\left({\color{red}5.84 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.1 \mathrm{ms} \pm 167 \mathrm{μs}\left({\color{gray}-4.083 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.2 \mathrm{ms} \pm 161 \mathrm{μs}\left({\color{gray}3.42 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$15.8 \mathrm{ms} \pm 185 \mathrm{μs}\left({\color{lightgreen}-6.191 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$15.9 \mathrm{ms} \pm 188 \mathrm{μs}\left({\color{lightgreen}-30.450 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.8 \mathrm{ms} \pm 203 \mathrm{μs}\left({\color{lightgreen}-7.265 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$67.0 \mathrm{ms} \pm 376 \mathrm{μs}\left({\color{gray}0.133 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$40.2 \mathrm{ms} \pm 235 \mathrm{μs}\left({\color{gray}1.80 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$57.8 \mathrm{ms} \pm 267 \mathrm{μs}\left({\color{gray}1.53 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$44.5 \mathrm{ms} \pm 178 \mathrm{μs}\left({\color{gray}2.10 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$49.3 \mathrm{ms} \pm 221 \mathrm{μs}\left({\color{gray}0.838 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$54.2 \mathrm{ms} \pm 325 \mathrm{μs}\left({\color{gray}1.21 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$103 \mathrm{ms} \pm 389 \mathrm{μs}\left({\color{gray}-0.698 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$40.3 \mathrm{ms} \pm 314 \mathrm{μs}\left({\color{gray}3.49 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$94.9 \mathrm{ms} \pm 354 \mathrm{μs}\left({\color{gray}-1.094 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$78.2 \mathrm{ms} \pm 255 \mathrm{μs}\left({\color{gray}1.36 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$88.1 \mathrm{ms} \pm 554 \mathrm{μs}\left({\color{gray}2.70 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$91.1 \mathrm{ms} \pm 394 \mathrm{μs}\left({\color{gray}0.939 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$2.13 \mathrm{ms} \pm 6.15 \mathrm{μs}\left({\color{gray}0.447 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$5.34 \mathrm{s} \pm 536 \mathrm{ms}\left({\color{gray}-1.016 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$26.8 \mathrm{ms} \pm 140 \mathrm{μs}\left({\color{gray}-0.254 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$20.8 \mathrm{ms} \pm 175 \mathrm{μs}\left({\color{gray}-0.489 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$57.0 \mathrm{ms} \pm 188 \mathrm{μs}\left({\color{gray}0.906 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$175 \mathrm{ms} \pm 697 \mathrm{μs}\left({\color{gray}-0.047 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$1.94 \mathrm{ms} \pm 5.75 \mathrm{μs}\left({\color{gray}0.765 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.14 \mathrm{ms} \pm 9.27 \mathrm{μs}\left({\color{gray}1.46 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$1.95 \mathrm{ms} \pm 4.77 \mathrm{μs}\left({\color{gray}-0.582 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.88 \mathrm{ms} \pm 13.0 \mathrm{μs}\left({\color{gray}1.41 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$9.58 \mathrm{ms} \pm 160 \mathrm{μs}\left({\color{lightgreen}-6.409 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$4.04 \mathrm{ms} \pm 17.0 \mathrm{μs}\left({\color{gray}-2.791 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.96 \mathrm{ms} \pm 11.1 \mathrm{μs}\left({\color{gray}0.957 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.94 \mathrm{ms} \pm 8.83 \mathrm{μs}\left({\color{gray}-0.795 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.06 \mathrm{ms} \pm 10.4 \mathrm{μs}\left({\color{gray}-1.445 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.28 \mathrm{ms} \pm 13.3 \mathrm{μs}\left({\color{gray}0.752 \mathrm{\%}}\right) $$ Flame Graph

@vilkinsons vilkinsons added this pull request to the merge queue Dec 20, 2024
@CiaranMn CiaranMn removed this pull request from the merge queue due to a manual request Dec 20, 2024
@CiaranMn CiaranMn added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 96fde7d Dec 20, 2024
165 of 166 checks passed
@CiaranMn CiaranMn deleted the cm/next-15 branch December 20, 2024 14:26
CiaranMn added a commit that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash.design Affects the `hash.design` design site (app) area/apps > hash.dev Affects the `hash.dev` developer site (app) area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps area/blocks Relates to first-party blocks (area) area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team
Development

Successfully merging this pull request may close these issues.

2 participants