Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3845: Fix Docker set up for Yarn 4 + Node 22 #5973

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

CiaranMn
Copy link
Member

🌟 What is the purpose of this PR?

Introduces some fixes to Dockerfiles necessary to use Yarn 4 with Node 22 to:

  1. enable corepack, with a directory that the runner user can write to
  2. Move some comments in the .env file so that they aren't parsed as values by Yarn can be parsed correctly

@github-actions github-actions bot added area/apps > hash* Affects HASH (a `hash-*` app) area/infra Relates to version control, CI, CD or IaC (area) area/infra > docker area/apps labels Dec 19, 2024
apps/hash-ai-worker-ts/docker/Dockerfile Dismissed Show dismissed Hide dismissed
apps/hash-integration-worker/docker/Dockerfile Dismissed Show dismissed Hide dismissed
infra/docker/api/prod/Dockerfile Dismissed Show dismissed Hide dismissed
@CiaranMn CiaranMn enabled auto-merge December 19, 2024 09:24
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.72%. Comparing base (7b35117) to head (708d83c).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5973   +/-   ##
=======================================
  Coverage   21.72%   21.72%           
=======================================
  Files         566      566           
  Lines       19157    19157           
  Branches     2752     2755    +3     
=======================================
  Hits         4162     4162           
  Misses      14943    14943           
  Partials       52       52           
Flag Coverage Δ
apps.hash-ai-worker-ts 1.32% <ø> (ø)
apps.hash-api 1.16% <ø> (ø)
blockprotocol.type-system 46.42% <ø> (ø)
local.harpc-client 50.17% <ø> (ø)
local.hash-backend-utils 8.81% <ø> (ø)
local.hash-graph-sdk 58.62% <ø> (ø)
local.hash-isomorphic-utils 0.98% <ø> (ø)
local.hash-subgraph 24.54% <ø> (ø)
rust.deer 6.66% <ø> (ø)
rust.error-stack 72.51% <ø> (ø)
rust.sarif 88.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CiaranMn CiaranMn added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 455572d Dec 19, 2024
165 checks passed
@CiaranMn CiaranMn deleted the cm/fix-docker-files-for-node22 branch December 19, 2024 09:50
Copy link
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$17.1 \mathrm{ms} \pm 178 \mathrm{μs}\left({\color{lightgreen}-28.072 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.4 \mathrm{ms} \pm 194 \mathrm{μs}\left({\color{gray}-0.511 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.5 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{lightgreen}-6.913 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.2 \mathrm{ms} \pm 167 \mathrm{μs}\left({\color{lightgreen}-11.665 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.5 \mathrm{ms} \pm 179 \mathrm{μs}\left({\color{lightgreen}-6.789 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.4 \mathrm{ms} \pm 161 \mathrm{μs}\left({\color{lightgreen}-5.775 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$15.7 \mathrm{ms} \pm 177 \mathrm{μs}\left({\color{lightgreen}-11.757 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$15.7 \mathrm{ms} \pm 175 \mathrm{μs}\left({\color{lightgreen}-35.745 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$15.8 \mathrm{ms} \pm 183 \mathrm{μs}\left({\color{lightgreen}-23.199 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$69.1 \mathrm{ms} \pm 315 \mathrm{μs}\left({\color{gray}1.56 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$39.2 \mathrm{ms} \pm 261 \mathrm{μs}\left({\color{lightgreen}-7.239 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$58.3 \mathrm{ms} \pm 329 \mathrm{μs}\left({\color{gray}-1.506 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$44.8 \mathrm{ms} \pm 294 \mathrm{μs}\left({\color{gray}-1.627 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$50.6 \mathrm{ms} \pm 180 \mathrm{μs}\left({\color{gray}0.422 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$54.9 \mathrm{ms} \pm 217 \mathrm{μs}\left({\color{gray}-3.019 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$107 \mathrm{ms} \pm 617 \mathrm{μs}\left({\color{gray}4.36 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$42.2 \mathrm{ms} \pm 124 \mathrm{μs}\left({\color{gray}3.47 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$101 \mathrm{ms} \pm 505 \mathrm{μs}\left({\color{gray}4.51 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$82.9 \mathrm{ms} \pm 267 \mathrm{μs}\left({\color{gray}4.78 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$92.3 \mathrm{ms} \pm 662 \mathrm{μs}\left({\color{gray}3.61 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$96.8 \mathrm{ms} \pm 325 \mathrm{μs}\left({\color{gray}4.41 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$2.12 \mathrm{ms} \pm 7.49 \mathrm{μs}\left({\color{gray}-0.643 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$5.60 \mathrm{s} \pm 283 \mathrm{ms}\left({\color{red}1972 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$26.5 \mathrm{ms} \pm 91.4 \mathrm{μs}\left({\color{gray}-2.005 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$20.4 \mathrm{ms} \pm 76.4 \mathrm{μs}\left({\color{gray}-2.999 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$56.8 \mathrm{ms} \pm 166 \mathrm{μs}\left({\color{gray}-2.696 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$174 \mathrm{ms} \pm 804 \mathrm{μs}\left({\color{gray}-3.589 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$1.94 \mathrm{ms} \pm 8.12 \mathrm{μs}\left({\color{gray}-0.407 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.11 \mathrm{ms} \pm 8.60 \mathrm{μs}\left({\color{gray}-1.229 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$1.94 \mathrm{ms} \pm 5.66 \mathrm{μs}\left({\color{gray}-2.199 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$3.09 \mathrm{ms} \pm 11.1 \mathrm{μs}\left({\color{red}6.34 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$13.3 \mathrm{ms} \pm 64.4 \mathrm{μs}\left({\color{red}31.9 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$4.17 \mathrm{ms} \pm 30.2 \mathrm{μs}\left({\color{gray}4.82 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.94 \mathrm{ms} \pm 10.1 \mathrm{μs}\left({\color{gray}-1.819 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.93 \mathrm{ms} \pm 11.7 \mathrm{μs}\left({\color{gray}-0.993 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.13 \mathrm{ms} \pm 9.36 \mathrm{μs}\left({\color{gray}-0.735 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$2.69 \mathrm{ms} \pm 9.43 \mathrm{μs}\left({\color{lightgreen}-18.823 \mathrm{\%}}\right) $$ Flame Graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps area/infra > docker area/infra Relates to version control, CI, CD or IaC (area)
Development

Successfully merging this pull request may close these issues.

2 participants