H-3879: Add protocol dropdown to early access form URL input #6106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/apps > hash*
vilkinsons
requested changes
Jan 10, 2025
There was a problem hiding this comment.
@CiaranMn Thanks! Can we please remove the whitespace/gap between the protocol dropdown input and the adjoining text input, so that are one contiguous component?
github-actions
bot
added
the
area/libs
|
@vilkinsons like this? Kapture.2025-01-10.at.12.28.34.mp4 |
vilkinsons
previously approved these changes
Jan 10, 2025
vilkinsons
approved these changes
Jan 10, 2025
|
Separate thread ongoing in Slack re: unsupported protocols here, and how we handle them across website URL inputs in HASH. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
We want to move property types which have URLs as their values to using the
URLdata type. This means values for them must pass URL validation, e.g. include a scheme at the start (https://) rather than just be e.g.example.comBut we also want users to be able to just type
example.cominto some inputs, e.g. in the early access form.This PR adds a protocol dropdown to the early access form's website URL input so that we can pass a full URL to the database but users don't have to type it out properly themselves.
It also allows for having a path in the URL (e.g.
example.com/my-page) which the early access form website URL input was previously not allowing.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
📹 Demo
Kapture.2025-01-10.at.12.09.24.mp4