Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate winnow to v0.6.24 #6122

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Update Rust crate winnow to v0.6.24 #6122

merged 2 commits into from
Jan 21, 2025

Conversation

hash-worker[bot]
Copy link
Contributor

@hash-worker hash-worker bot commented Jan 11, 2025

This PR contains the following updates:

Package Type Update Change
winnow workspace.dependencies patch =0.6.22 -> =0.6.24

Release Notes

winnow-rs/winnow (winnow)

v0.6.24

Compare Source

Fixes
  • Add back in winnow::Located which was removed by accident

v0.6.23

Compare Source

Compatibiloty
  • stream::Located is deprecated in favor of stream::LocatingSlice
  • combnator::rest is deprecated in favor of token::rest
  • combnator::rest_len is deprecated in favor of token::rest_len
  • combinator::<Struct> have mostly been deprecated in favor of combinator::impls::<Struct>
  • unpeek is deprecated
Features
  • Added repeat().try_fold() and repeat().verify_fold()

Configuration

📅 Schedule: Branch creation - "before 4am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@hash-worker hash-worker bot enabled auto-merge January 11, 2025 02:30
hashdotai
hashdotai previously approved these changes Jan 11, 2025
@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team labels Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.82%. Comparing base (bb61077) to head (1a5ca1d).
Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6122      +/-   ##
==========================================
+ Coverage   21.72%   21.82%   +0.09%     
==========================================
  Files         566      569       +3     
  Lines       19156    19478     +322     
  Branches     2755     2826      +71     
==========================================
+ Hits         4162     4251      +89     
- Misses      14942    15175     +233     
  Partials       52       52              
Flag Coverage Δ
apps.hash-ai-worker-ts 1.28% <ø> (-0.04%) ⬇️
apps.hash-api 1.16% <ø> (-0.01%) ⬇️
blockprotocol.type-system 46.42% <ø> (ø)
local.harpc-client 50.17% <ø> (ø)
local.hash-backend-utils 8.81% <ø> (ø)
local.hash-graph-sdk 58.62% <ø> (ø)
local.hash-isomorphic-utils 0.95% <ø> (-0.03%) ⬇️
local.hash-subgraph 24.54% <ø> (ø)
rust.deer 6.66% <ø> (ø)
rust.error-stack 72.53% <ø> (+0.02%) ⬆️
rust.sarif 88.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hash-worker
Copy link
Contributor Author

hash-worker bot commented Jan 21, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$15.8 \mathrm{ms} \pm 149 \mathrm{μs}\left({\color{lightgreen}-30.873 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.1 \mathrm{ms} \pm 182 \mathrm{μs}\left({\color{gray}-1.555 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$15.7 \mathrm{ms} \pm 182 \mathrm{μs}\left({\color{gray}-1.092 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.2 \mathrm{ms} \pm 185 \mathrm{μs}\left({\color{red}5.98 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.5 \mathrm{ms} \pm 166 \mathrm{μs}\left({\color{gray}0.890 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.1 \mathrm{ms} \pm 189 \mathrm{μs}\left({\color{gray}-4.618 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.9 \mathrm{ms} \pm 232 \mathrm{μs}\left({\color{gray}4.80 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$15.7 \mathrm{ms} \pm 154 \mathrm{μs}\left({\color{lightgreen}-31.630 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$16.0 \mathrm{ms} \pm 158 \mathrm{μs}\left({\color{gray}4.04 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$65.4 \mathrm{ms} \pm 272 \mathrm{μs}\left({\color{gray}0.316 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$37.3 \mathrm{ms} \pm 189 \mathrm{μs}\left({\color{gray}-0.718 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$55.6 \mathrm{ms} \pm 284 \mathrm{μs}\left({\color{gray}0.126 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$42.0 \mathrm{ms} \pm 192 \mathrm{μs}\left({\color{gray}-0.225 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$47.8 \mathrm{ms} \pm 329 \mathrm{μs}\left({\color{gray}0.846 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$52.2 \mathrm{ms} \pm 366 \mathrm{μs}\left({\color{gray}0.701 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$97.7 \mathrm{ms} \pm 530 \mathrm{μs}\left({\color{gray}0.031 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$37.4 \mathrm{ms} \pm 248 \mathrm{μs}\left({\color{gray}0.336 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$88.6 \mathrm{ms} \pm 409 \mathrm{μs}\left({\color{gray}-0.367 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$71.6 \mathrm{ms} \pm 293 \mathrm{μs}\left({\color{gray}-0.357 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$80.3 \mathrm{ms} \pm 263 \mathrm{μs}\left({\color{gray}-0.263 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$85.8 \mathrm{ms} \pm 631 \mathrm{μs}\left({\color{gray}1.22 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$2.17 \mathrm{ms} \pm 9.66 \mathrm{μs}\left({\color{gray}1.34 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$5.67 \mathrm{s} \pm 287 \mathrm{ms}\left({\color{red}5.24 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$27.4 \mathrm{ms} \pm 112 \mathrm{μs}\left({\color{gray}0.845 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$20.9 \mathrm{ms} \pm 81.7 \mathrm{μs}\left({\color{gray}-1.780 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$57.5 \mathrm{ms} \pm 222 \mathrm{μs}\left({\color{gray}0.405 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$177 \mathrm{ms} \pm 824 \mathrm{μs}\left({\color{gray}-0.029 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$2.02 \mathrm{ms} \pm 12.2 \mathrm{μs}\left({\color{gray}0.935 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.23 \mathrm{ms} \pm 11.7 \mathrm{μs}\left({\color{red}5.91 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.01 \mathrm{ms} \pm 7.27 \mathrm{μs}\left({\color{gray}-0.089 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.91 \mathrm{ms} \pm 10.2 \mathrm{μs}\left({\color{gray}-1.729 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$9.27 \mathrm{ms} \pm 88.8 \mathrm{μs}\left({\color{lightgreen}-32.146 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$4.33 \mathrm{ms} \pm 18.6 \mathrm{μs}\left({\color{gray}4.49 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$2.01 \mathrm{ms} \pm 10.3 \mathrm{μs}\left({\color{gray}-0.224 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$2.00 \mathrm{ms} \pm 9.96 \mathrm{μs}\left({\color{gray}0.223 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.22 \mathrm{ms} \pm 11.5 \mathrm{μs}\left({\color{gray}1.04 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.39 \mathrm{ms} \pm 14.9 \mathrm{μs}\left({\color{gray}-0.227 \mathrm{\%}}\right) $$ Flame Graph

@hash-worker hash-worker bot added this pull request to the merge queue Jan 21, 2025
Merged via the queue into main with commit 3206659 Jan 21, 2025
144 checks passed
@hash-worker hash-worker bot deleted the deps/rs/winnow-0.x branch January 21, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deps Relates to third-party dependencies (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team
Development

Successfully merging this pull request may close these issues.

3 participants