Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security label for vulnerability Alerts #81

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Add security label for vulnerability Alerts #81

merged 3 commits into from
Nov 16, 2023

Conversation

taxintt
Copy link
Contributor

@taxintt taxintt commented Nov 13, 2023 •
edited
Loading

@taxintt taxintt self-assigned this Nov 13, 2023
@taxintt taxintt marked this pull request as ready for review November 13, 2023 04:23
@taxintt taxintt requested a review from ikesyo November 16, 2023 03:58
ikesyo
ikesyo reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert final new lines changes? Otherwise looks good 👍

default.json Outdated Show resolved Hide resolved
vulnerabilityAlerts.json Outdated Show resolved Hide resolved
vulnerabilityAlerts.json
Comment on lines +2 to +6
"vulnerabilityAlerts": {
"labels": [
"security"
]
}
Copy link
Contributor

@ikesyo ikesyo Nov 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 This setting is exemplified in the document.

image

@taxintt taxintt requested a review from ikesyo November 16, 2023 04:52
ikesyo
ikesyo approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ikesyo ikesyo merged commit d7d5b39 into main Nov 16, 2023
1 check passed
@ikesyo ikesyo deleted the feat/add-security-label-for-vulnerability-alerts branch November 16, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikesyo ikesyo ikesyo approved these changes

Assignees

@taxintt taxintt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taxintt @ikesyo